Skip to content

Commit

Permalink
precompiled: adjust the gas cost of consortium precompiled contract
Browse files Browse the repository at this point in the history 
This commit adds the benchmarks and calculated gas cost from the benchmarks to
validator sorting, pick validator set and verify double sign proof precompiled
contracts. Ethereum aims for 30 mgas/s when setting gas cost for precompiled
contracts, we aims for 60 mgas/s.

Benchmark results:

BenchmarkConsortiumValidatorSorting/validator-sort-Gas=4620-8             228014             54940 ns/op              4620 gas/op               84.09 mgas/s       35755 B/op        560 allocs/op
BenchmarkConsortiumValidatorSorting/validator-sort-Gas=19560-8             60619            182986 ns/op             19560 gas/op              106.9 mgas/s       148101 B/op       2342 allocs/op
BenchmarkConsortiumVerifyHeaders/verify-headers-Gas=24000-8                32920            354968 ns/op             24000 gas/op               67.61 mgas/s       97101 B/op        924 allocs/op
BenchmarkConsortiumPickValidatorSet/pick-validator-set-Gas=7080-8          128181             86701 ns/op              7080 gas/op               81.65 mgas/s       50221 B/op        684 allocs/op
BenchmarkConsortiumPickValidatorSet/pick-validator-set-Gas=29580-8          53889            244067 ns/op             29580 gas/op              121.2 mgas/s       179618 B/op       2597 allocs/op
  • Loading branch information
@minh-bq
minh-bq committed Nov 14, 2023
1 parent ee4da5a commit 60542f6
Show file tree
Hide file tree
Showing 4 changed files with 231 additions and 30 deletions.
85 changes: 60 additions & 25 deletions core/vm/consortium_precompiled_contracts.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -89,16 +89,28 @@ type consortiumPickValidatorSet struct {
evm *EVM
}

func (c *consortiumPickValidatorSet) RequiredGas(_ []byte) uint64 {
return 0
func (c *consortiumPickValidatorSet) RequiredGas(input []byte) uint64 {
// c.evm is nil in benchmark
if c.evm == nil || c.evm.chainRules.IsMiko {
// We approximate the number of validators by dividing the length of input by
// length of address (20). This is likely an overestimation because there are
// slices of weight, maxValidatorNumber and maxPrioritizedValidatorNumber in
// the input too.
return uint64((len(input) / common.AddressLength)) * params.ValidatorSortingBaseGas
} else {
return 0
}
}

func (c *consortiumPickValidatorSet) Run(input []byte) ([]byte, error) {
if c.evm.ChainConfig().ConsortiumV2Contracts == nil {
return nil, errors.New("cannot find consortium v2 contracts")
}
if !c.evm.ChainConfig().ConsortiumV2Contracts.IsSystemContract(c.caller.Address()) {
return nil, errors.New("unauthorized sender")
// These 2 fields are nil in benchmark only
if c.caller != nil && c.evm != nil {
if c.evm.ChainConfig().ConsortiumV2Contracts == nil {
return nil, errors.New("cannot find consortium v2 contracts")
}
if !c.evm.ChainConfig().ConsortiumV2Contracts.IsSystemContract(c.caller.Address()) {
return nil, errors.New("unauthorized sender")
}
}
// get method, args from abi
_, method, args, err := loadMethodAndArgs(consortiumPickValidatorSetAbi, input)
Expand Down Expand Up @@ -216,16 +228,27 @@ type consortiumValidatorSorting struct {
evm *EVM
}

func (c *consortiumValidatorSorting) RequiredGas(_ []byte) uint64 {
return 0
func (c *consortiumValidatorSorting) RequiredGas(input []byte) uint64 {
// c.evm is nil in benchmark
if c.evm == nil || c.evm.chainRules.IsMiko {
// We approximate the number of validators by dividing the length of input by
// length of address (20). This is likely an overestimation because there is
// a slice of weight in the input too.
return uint64((len(input) / common.AddressLength)) * params.ValidatorSortingBaseGas
} else {
return 0
}
}

func (c *consortiumValidatorSorting) Run(input []byte) ([]byte, error) {
if c.evm.ChainConfig().ConsortiumV2Contracts == nil {
return nil, errors.New("cannot find consortium v2 contracts")
}
if !c.evm.ChainConfig().ConsortiumV2Contracts.IsSystemContract(c.caller.Address()) {
return nil, errors.New("unauthorized sender")
// These 2 fields are nil in benchmark only
if c.caller != nil && c.evm != nil {
if c.evm.ChainConfig().ConsortiumV2Contracts == nil {
return nil, errors.New("cannot find consortium v2 contracts")
}
if !c.evm.ChainConfig().ConsortiumV2Contracts.IsSystemContract(c.caller.Address()) {
return nil, errors.New("unauthorized sender")
}
}
// get method, args from abi
_, method, args, err := loadMethodAndArgs(consortiumSortValidatorAbi, input)
Expand Down Expand Up @@ -364,15 +387,23 @@ type consortiumVerifyHeaders struct {
}

func (c *consortiumVerifyHeaders) RequiredGas(_ []byte) uint64 {
return 0
// c.evm is nil in benchmark
if c.evm == nil || c.evm.chainRules.IsMiko {
return params.VerifyFinalityHeadersProofGas
} else {
return 0
}
}

func (c *consortiumVerifyHeaders) Run(input []byte) ([]byte, error) {
if c.evm.ChainConfig().ConsortiumV2Contracts == nil {
return nil, errors.New("cannot find consortium v2 contracts")
}
if !c.evm.ChainConfig().ConsortiumV2Contracts.IsSystemContract(c.caller.Address()) {
return nil, errors.New("unauthorized sender")
// These 2 fields are nil in benchmark only
if c.caller != nil && c.evm != nil {
if c.evm.ChainConfig().ConsortiumV2Contracts == nil {
return nil, errors.New("cannot find consortium v2 contracts")
}
if !c.evm.ChainConfig().ConsortiumV2Contracts.IsSystemContract(c.caller.Address()) {
return nil, errors.New("unauthorized sender")
}
}
// get method, args from abi
smcAbi, method, args, err := loadMethodAndArgs(consortiumVerifyHeadersAbi, input)
Expand Down Expand Up @@ -438,7 +469,8 @@ func (c *consortiumVerifyHeaders) getSigner(header types.BlockHeader) (common.Ad
func (c *consortiumVerifyHeaders) verify(consensusAddr common.Address, header1, header2 types.BlockHeader) bool {
var maxOffset *big.Int

if !c.evm.chainConfig.IsConsortiumV2(header1.Number) {
// c.evm s nil in benchmark, so we skip this check in benchmark
if c.evm != nil && !c.evm.chainConfig.IsConsortiumV2(header1.Number) {
return false
}
if header1.ToHeader().ParentHash.Hex() != header2.ToHeader().ParentHash.Hex() {
Expand Down Expand Up @@ -487,10 +519,13 @@ func (c *consortiumVerifyHeaders) verify(consensusAddr common.Address, header1,
}
}

currentBlock := c.evm.Context.BlockNumber
// What if current block < header1.Number?
if currentBlock.Cmp(header1.Number) > 0 && new(big.Int).Sub(currentBlock, header1.Number).Cmp(maxOffset) > 0 {
return false
// c.evm is nil in benchmark, so we skip this check in benchmark
if c.evm != nil {
currentBlock := c.evm.Context.BlockNumber
// What if current block < header1.Number?
if currentBlock.Cmp(header1.Number) > 0 && new(big.Int).Sub(currentBlock, header1.Number).Cmp(maxOffset) > 0 {
return false
}
}

return signer1.Hex() == signer2.Hex() &&
Expand Down
Loading

0 comments on commit 60542f6

Please sign in to comment.