Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore HiddenSpace secondary display on one UI 6 #161

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Xtr126
Copy link
Contributor

@Xtr126 Xtr126 commented Jun 2, 2024

When mirroring screen wirelessly, two displays are created by smart view. Smart dock picks the wrong display by default. This patch fixes it. Tested and working fine on one UI 6.

@Xtr126
Copy link
Contributor Author

Xtr126 commented Jun 19, 2024

Later only I found out, HiddenSpace is the display used by "App Cast" feature.

@axel358
Copy link
Owner

axel358 commented Nov 16, 2024

Is this still relevant?

@Xtr126
Copy link
Contributor Author

Xtr126 commented Nov 16, 2024

Not sure what you mean, but still on my device, cannot use smart dock on secondary display without the patch.

@axel358
Copy link
Owner

axel358 commented Nov 20, 2024

@Xtr126 Sorry if that came out a little rough 😅. What I was asking about was whether you had found any other ways to do things before merging it

@Xtr126
Copy link
Contributor Author

Xtr126 commented Nov 21, 2024

@Xtr126 Sorry if that came out a little rough 😅. What I was asking about was whether you had found any other ways to do things before merging it

I'm open to any questions, but I wanted some clarification.
We are grateful for the amazing free and open source software.
Three other options:

  1. Checking Display.getFlags() to guess the external display
  2. By showing a dialog or somehow, actually letting user select a preferred external display.
  3. Android itself tends to show the cursor on the largest display when there is more than one display, that could be used as a metric too.

@axel358
Copy link
Owner

axel358 commented Nov 23, 2024

@Xtr126 I have considered number 2 in the past actually. Maybe we could give it a try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants