Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated create amo file and contribution file #639

Merged
merged 3 commits into from
Nov 6, 2018

Conversation

AndyOGo
Copy link

@AndyOGo AndyOGo commented Oct 25, 2018

Fixes #631

Changes proposed in this pull request:

  • updated amo script
  • added note about HTML attributes

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@AndyOGo AndyOGo self-assigned this Oct 25, 2018
@AndyOGo AndyOGo requested a review from LucaMele October 25, 2018 06:40
@AndyOGo AndyOGo changed the title updated create amo file updated create amo file and contribution file Oct 25, 2018
@AndyOGo AndyOGo added this to the Application Suitability milestone Nov 5, 2018
Copy link
Contributor

@LucaMele LucaMele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks andy

@AndyOGo AndyOGo merged commit 9134792 into develop Nov 6, 2018
@AndyOGo AndyOGo deleted the bugfix/update-create-amo-for-prop-types-changes branch November 6, 2018 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Production prop types all doomed
2 participants