Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workaround for read hangs during restart #3

Merged
merged 1 commit into from
Jan 7, 2015
Merged

workaround for read hangs during restart #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/picongpu/include/plugins/hdf5/restart/LoadParticleAttributesFromHDF5.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,17 @@ struct LoadParticleAttributesFromHDF5
ComponentType* tmpArray = NULL;
if( elements > 0 )
tmpArray = new ComponentType[elements];
else
{
/** This is a workaround to avoid the bug that processes hangs
* if some call `DataCollector::read()` where elements to read is
* zero and the destination pointer for the read data is set to `NULL`.
* see: - `PIconGPU` issu: https://github.com/ComputationalRadiationPhysics/picongpu/pull/611
* - `libSplash` issu: https://github.com/ComputationalRadiationPhysics/libSplash/issues/148
* \todo: please remove this workaround after the libsplash bug is fixed
*/
tmpArray = new ComponentType[1];
}

ParallelDomainCollector* dataCollector = params->dataCollector;
for (uint32_t d = 0; d < components; d++)
Expand Down