Update aws-sdk to 1 #736
Closed
Update aws-sdk to 1 #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpculp
reviewed
Dec 12, 2023
| dependencies = [ | ||
| "aws-smithy-types", | ||
| "urlencoding", | ||
| ] | ||
|
|
||
| [[package]] | ||
| name = "aws-smithy-runtime" | ||
| version = "0.57.2" | ||
| version = "1.1.0" |
There was a problem hiding this comment.
Can this be 1.0.3 to avoid pulling in two versions of aws-smithy-http?
There was a problem hiding this comment.
Only one major version will be allowed anyway, so a distinction between "1.1" and "1.0" is not meaningful (the lock file will not be consulted when using a lib from an external project). Not sure if I'm missing something.
262cad4 to
000ef5d
Compare
jpculp
reviewed
Dec 12, 2023
tough-kms/Cargo.toml
Outdated
| aws-smithy-http = "0.57" | ||
| aws-smithy-types = "0.57" | ||
| aws-smithy-runtime = {version = "1.0", features = ["test-util"]} | ||
| aws-smithy-types = "1.1" |
There was a problem hiding this comment.
Should we make types "1.0" too and make sure aws-smithy-runtime-api and aws-smithy-async are also 1.0.3? (not sure what happens if we have mixed versions)
There was a problem hiding this comment.
We should make these say "1", not "1.1".
webern
reviewed
Dec 12, 2023
tough-kms/Cargo.toml
Outdated
| @@ -16,16 +16,15 @@ aws-sdk-rust-rustls = ["aws-config/rustls", "aws-sdk-kms/rustls"] | |||
| [dependencies] | |||
| tough = { version = "0.16", path = "../tough", features = ["http"] } | |||
| ring = { version = "0.17", features = ["std"] } | |||
| aws-sdk-kms = "0.36" | |||
| aws-config = "0.57" | |||
| aws-sdk-kms = { version = "1.4", features = ["behavior-version-latest"] } | |||
There was a problem hiding this comment.
Suggested change
| aws-sdk-kms = { version = "1.4", features = ["behavior-version-latest"] } | |
| aws-sdk-kms = { version = "1", features = ["behavior-version-latest"] } |
tough-kms/Cargo.toml
Outdated
| aws-sdk-kms = "0.36" | ||
| aws-config = "0.57" | ||
| aws-sdk-kms = { version = "1.4", features = ["behavior-version-latest"] } | ||
| aws-config = { version = "1.0", features = ["behavior-version-latest"] } |
There was a problem hiding this comment.
Suggested change
| aws-config = { version = "1.0", features = ["behavior-version-latest"] } | |
| aws-config = { version = "1", features = ["behavior-version-latest"] } |
tough-kms/Cargo.toml
Outdated
| aws-smithy-runtime = {version = "0.57", features = ["test-util"]} | ||
| aws-smithy-http = "0.57" | ||
| aws-smithy-types = "0.57" | ||
| aws-smithy-runtime = {version = "1.0", features = ["test-util"]} |
There was a problem hiding this comment.
Suggested change
| aws-smithy-runtime = {version = "1.0", features = ["test-util"]} | |
| aws-smithy-runtime = {version = "1", features = ["test-util"]} |
tough-kms/Cargo.toml
Outdated
| aws-smithy-http = "0.57" | ||
| aws-smithy-types = "0.57" | ||
| aws-smithy-runtime = {version = "1.0", features = ["test-util"]} | ||
| aws-smithy-types = "1.1" |
There was a problem hiding this comment.
Suggested change
| aws-smithy-types = "1.1" | |
| aws-smithy-types = "1" |
tough-ssm/Cargo.toml
Outdated
| @@ -15,7 +15,7 @@ aws-sdk-rust-rustls = ["aws-config/rustls", "aws-sdk-ssm/rustls"] | |||
|
|
|||
| [dependencies] | |||
| tough = { version = "0.16", path = "../tough", features = ["http"] } | |||
| aws-sdk-ssm = "0.36" | |||
| aws-config = "0.57" | |||
| aws-sdk-ssm = "1.4" | |||
There was a problem hiding this comment.
Suggested change
| aws-sdk-ssm = "1.4" | |
| aws-sdk-ssm = "1" |
tough-ssm/Cargo.toml
Outdated
| aws-sdk-ssm = "0.36" | ||
| aws-config = "0.57" | ||
| aws-sdk-ssm = "1.4" | ||
| aws-config = { version = "1.0", features = ["behavior-version-latest"] } |
There was a problem hiding this comment.
Suggested change
| aws-config = { version = "1.0", features = ["behavior-version-latest"] } | |
| aws-config = { version = "1", features = ["behavior-version-latest"] } |
tuftool/Cargo.toml
Outdated
Comment on lines
18
to
20
| aws-config = { version = "1.0", features = ["behavior-version-latest"] } | ||
| aws-sdk-kms = "1.4" | ||
| aws-sdk-ssm = "1.4" |
There was a problem hiding this comment.
Suggested change
| aws-config = { version = "1.0", features = ["behavior-version-latest"] } | |
| aws-sdk-kms = "1.4" | |
| aws-sdk-ssm = "1.4" | |
| aws-config = { version = "1", features = ["behavior-version-latest"] } | |
| aws-sdk-kms = "1" | |
| aws-sdk-ssm = "1" |
000ef5d to
155f8a8
Compare
|
^ Updated aws-sdk dependencies to to update |
jpculp
approved these changes
Dec 13, 2023
webern
approved these changes
Dec 13, 2023
|
Superseded by #751 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Updates the AWS SDK for rust to
1.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.