Fix up path prefix check for windows #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stmcginnis
approved these changes
Aug 19, 2023
webern
approved these changes
Aug 21, 2023
tough/src/target_name.rs
Outdated
Comment on lines
140
to
141
| // If the first component isn't the main separator ( unix `/`, windows '\' ) then there is a bug or behavior change in | ||
| // absolutize_from. |
There was a problem hiding this comment.
Nit: we wrap comments at 100-char width.
Suggested change
| // If the first component isn't the main separator ( unix `/`, windows '\' ) then there is a bug or behavior change in | |
| // absolutize_from. | |
| // If the first component isn't the main separator ( unix `/`, windows '\' ) then there | |
| // is a bug or behavior change in absolutize_from. |
There was a problem hiding this comment.
I've updated that. I thought that would be handled by rustfmt.
|
I guess |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#347 (somewhat, I think)
Description of changes:
When loading a repository, the absolutized path will start with \ instead of /, so I changed It to use
std::path::MAIN_SEPARATOR_STR. This allows me to use the Repository struct on Windows properly.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.