Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix all_targets iterator type #562

Merged
merged 1 commit into from
Jan 23, 2023
Merged

fix all_targets iterator type #562

merged 1 commit into from
Jan 23, 2023

Conversation

webern
Copy link
Contributor

@webern webern commented Jan 23, 2023

Issue #, if available:

Fixes #560

Description of changes:

Include the type in an impl Iterator return so that the return type is usable.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@stmcginnis stmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, all checks have passed.

@webern webern merged commit d62c98d into awslabs:develop Jan 23, 2023
@webern webern deleted the all-targets branch January 23, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repository::all_targets() cannot actually be used
3 participants