Bugfix ignore regexes #172

ChrisPates · 2024-02-29T11:17:22Z

Issue #, if available:
#169
#170
#171

Description of changes:

Updated regex in template to be correct for the parameters,
Updated SourceCodeUrl to head of master branch
Fixed the interpretation of secret arns from lambda environment variable
- GOOGLE_CREDENTIALS
- GOOGLE_ADMIN
- SCIM_ENDPOINT
- SCIM_ACCESS_TOKEN
- REGION
- IDENTITY_STORE_ID
Fixed reading none-secret values that have default values from lambda environment variables
- LOG_LEVEL
- LOG_FORMAT
- SYNC_METHOD
Change when log channel configured to respect log settings from above variables
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Allow: - empty parameter (env var not created) or - One or more email addresses

Adding missing permissions to developer.yml

added missing env var parameter

Change Secret names in this stack to avoid collision with previously used names.

Update to use same buildspecs as in the release pipeline.

update cleanup stage to remove the correct stack.

Changed Source code Url to be head of master.

Despite passing the secrets arns to the function via the env variables. This were never actually used instead using hard code secret short names.

Remove redundant prefix from Env var names.

Adding import for os module

Adding missing permission to CLI test role.

Copy arm64 executable to correct path for building SAM package

Actually read secret arn from Env Var, and use fall back to old static names if the Env is missing or empty.

Checking whether case-sensetivity is impacts the import of envs

This reverts commit 96f9ccb.

This reverts commit 5b54099.

This reverts commit 29315a1.

viper doesn't handle lambda Env Vars well, so conditionally overriding normal viper behaviour.

Changed logConfig timing so log settings from Lambda Env Vars are respected.

ChrisPates added 7 commits February 28, 2024 14:02

Update regexes for ignore and include parameters

9aca68f

Allow: - empty parameter (env var not created) or - One or more email addresses

update developer pipeline template

a220403

Adding missing permissions to developer.yml

Update developer.yaml

76e93d7

added missing env var parameter

Update secrets.yaml

797654b

Change Secret names in this stack to avoid collision with previously used names.

Update developer.yaml

21ce3d3

Update to use same buildspecs as in the release pipeline.

Update developer.yaml

e107cf6

update cleanup stage to remove the correct stack.

Update template.yaml

d19ec8b

Changed Source code Url to be head of master.

ChrisPates marked this pull request as draft February 29, 2024 11:33

ChrisPates added 15 commits February 29, 2024 12:11

Running Test this commit will be rolled back.

cad5e0d

Retrieve secret arns from env vars

e7ef19a

Despite passing the secrets arns to the function via the env variables. This were never actually used instead using hard code secret short names.

Update template.yaml

aa3e6a1

Remove redundant prefix from Env var names.

Update secrets.go

63c7f63

Adding import for os module

Update developer.yaml

a42f0a6

Adding missing permission to CLI test role.

Update Makefile

432ac49

Copy arm64 executable to correct path for building SAM package

Read secret arn from Env Var,

7cae95f

Actually read secret arn from Env Var, and use fall back to old static names if the Env is missing or empty.

case-sensetivity env vars?

96f9ccb

Checking whether case-sensetivity is impacts the import of envs

Revert "case-sensetivity env vars?"

fd3d26c

This reverts commit 96f9ccb.

Update config.go

5b54099

Update config_test.go

29315a1

Revert "Update config.go"

26243c9

This reverts commit 5b54099.

Revert "Update config_test.go"

90bba62

This reverts commit 29315a1.

Bypass viper for lambda Env Vars

5339ebd

viper doesn't handle lambda Env Vars well, so conditionally overriding normal viper behaviour.

Update root.go

3607b2e

Changed logConfig timing so log settings from Lambda Env Vars are respected.

ChrisPates marked this pull request as ready for review March 1, 2024 18:02

ChrisPates self-assigned this Mar 1, 2024

ChrisPates merged commit 53b575b into master Mar 1, 2024
1 check passed

ChrisPates deleted the bugfix_ignore_regexes branch March 1, 2024 19:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bugfix ignore regexes #172

Bugfix ignore regexes #172

ChrisPates commented Feb 29, 2024 •

edited

Loading

Bugfix ignore regexes #172

Bugfix ignore regexes #172

Conversation

ChrisPates commented Feb 29, 2024 • edited Loading

ChrisPates commented Feb 29, 2024 •

edited

Loading