Update deprecated packages #1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github.com/containerd/containerd/platforms -> github.com/containerd/platforms github.com/containerd/containerd/reference/docker -> github.com/distribution/reference Signed-off-by: David Son <davbson@amazon.com>
853acc6 to
28ae51d
Compare
pendo324
approved these changes
Jul 9, 2024
Kern--
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
#1307 had some failing lint checks due to deprecated containerd packages. This updates code references to point to the new packages.
You can see the lint action passing with the dependabot changes here: https://github.com/sondavidb/soci-snapshotter/actions/runs/9862588798?pr=17
Once done we should rebase #1307.
Testing performed:
I first pulled from the dependabot branch, made my changes, then ran the below commands:
golangci-lint run ./...cd cmd && golangci-lint run ./...By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.