Skip to content
This repository has been archived by the owner on Dec 6, 2024. It is now read-only.

docs: rstudio doc updates #827

Merged
merged 1 commit into from
Dec 6, 2021
Merged

Conversation

shyogesh-sw
Copy link
Contributor

Issue #, if available: GALI-1250

Description of changes: New section added in the installation on installing RStudio workspace.

Checklist:

  • Have you successfully deployed to an AWS account with your changes?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully tested with your changes locally?
  • If new dependencies have been added, have they been pinned to specific versions?
  • Is this change also required on the AWS Solution version?
  • Have you updated openapi.yaml if you made updates to API definition (including add, delete or update parameter and request data schema)?
  • If you had to run manual tests, have you considered automating those tests by adding them to end-to-end tests?
  • If you are updating the changelog and vending out a new release, have you updated versionNumber and versionDate in .defaults.yml

AS review ticket id:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@shyogesh-sw shyogesh-sw requested a review from a team as a code owner December 6, 2021 20:51
@codecov
Copy link

codecov bot commented Dec 6, 2021

Codecov Report

Merging #827 (0710518) into develop (ea93a8c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #827   +/-   ##
========================================
  Coverage    50.91%   50.91%           
========================================
  Files          286      286           
  Lines        15931    15931           
  Branches      2488     2484    -4     
========================================
  Hits          8111     8111           
  Misses        6863     6863           
  Partials       957      957           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea93a8c...0710518. Read the comment docs.

Copy link
Contributor

@maghirardelli maghirardelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for this!

@maghirardelli maghirardelli merged commit 772617f into awslabs:develop Dec 6, 2021
jxuamazon pushed a commit to jxuamazon/service-workbench-on-aws that referenced this pull request Feb 15, 2022
Co-authored-by: Sharma <shyogesh@88665a06ebc4.ant.amazon.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants