Skip to content
This repository has been archived by the owner on Dec 6, 2024. It is now read-only.

fix: hsts header #790

Merged
merged 4 commits into from
Nov 10, 2021
Merged

fix: hsts header #790

merged 4 commits into from
Nov 10, 2021

Conversation

maghirardelli
Copy link
Contributor

Issue #, if available: GALI-1190

Description of changes: Added a strict-transport-security header to enforce HSTS traffic for extra security.

Tested manually and was able to see the proper header in the response in both the UI and through Postman. Ran the entire collection of integration tests and end-to-end tests and all passed. Manually tested in both non-TRE and TRE environments.

Header in response:
Screen Shot 2021-11-04 at 4 06 20 PM

Checklist:

  • Have you successfully deployed to an AWS account with your changes?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully tested with your changes locally?

AS review ticket id:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@maghirardelli maghirardelli requested a review from a team as a code owner November 9, 2021 15:07
@maghirardelli maghirardelli self-assigned this Nov 9, 2021
@github-actions github-actions bot added the size/s label Nov 9, 2021
@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #790 (24f0b17) into develop (0967129) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #790   +/-   ##
========================================
  Coverage    50.46%   50.46%           
========================================
  Files          279      279           
  Lines        15152    15152           
  Branches      2404     2405    +1     
========================================
  Hits          7647     7647           
  Misses        6573     6573           
  Partials       932      932           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0967129...24f0b17. Read the comment docs.

@maghirardelli maghirardelli merged commit 66f79f2 into develop Nov 10, 2021
@maghirardelli maghirardelli deleted the fix-hsts-header branch November 10, 2021 21:14
jxuamazon pushed a commit to jxuamazon/service-workbench-on-aws that referenced this pull request Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants