Skip to content
This repository has been archived by the owner on Dec 6, 2024. It is now read-only.

fix: sc portfolio deletion correction #779

Merged
merged 4 commits into from
Nov 12, 2021
Merged

fix: sc portfolio deletion correction #779

merged 4 commits into from
Nov 12, 2021

Conversation

SanketD92
Copy link
Contributor

Issue #, if available:
SC portfolio doesn't delete if in a different region.

Description of changes:
SC Portfolio deletion correction.

Checklist:

  • Have you successfully deployed to an AWS account with your changes?
  • Have you successfully tested with your changes locally?

AS review ticket id:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@SanketD92 SanketD92 requested a review from a team as a code owner October 28, 2021 15:40
@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #779 (99d1ce3) into develop (9840e2c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #779   +/-   ##
========================================
  Coverage    50.46%   50.46%           
========================================
  Files          279      279           
  Lines        15152    15152           
  Branches      2405     2404    -1     
========================================
  Hits          7647     7647           
  Misses        6573     6573           
  Partials       932      932           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9840e2c...99d1ce3. Read the comment docs.

@SanketD92 SanketD92 requested a review from a team as a code owner November 12, 2021 16:48
@SanketD92 SanketD92 merged commit 6e4d67b into develop Nov 12, 2021
@SanketD92 SanketD92 deleted the fix-delete-script branch November 12, 2021 16:56
jxuamazon pushed a commit to jxuamazon/service-workbench-on-aws that referenced this pull request Feb 15, 2022
Co-authored-by: Tim Nguyen <nguyen102@users.noreply.github.com>
Co-authored-by: Jeet <68876606+jn1119@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants