Skip to content
This repository has been archived by the owner on Dec 6, 2024. It is now read-only.

fix: display unavailable after config deletion #760

Merged
merged 2 commits into from
Oct 18, 2021

Conversation

maghirardelli
Copy link
Contributor

Issue #, if available:

Description of changes: Display "Unavailable" in the workspace details card for name and instance type when the configuration for that workspace has been deleted.

Screen Shot 2021-10-18 at 4 04 41 PM

Checklist:
  • Have you successfully deployed to an AWS account with your changes?

AS review ticket id:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@maghirardelli maghirardelli requested a review from a team as a code owner October 18, 2021 20:11
@maghirardelli maghirardelli self-assigned this Oct 18, 2021
@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #760 (f8d8852) into develop (0119e7d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #760   +/-   ##
========================================
  Coverage    52.09%   52.09%           
========================================
  Files          272      272           
  Lines        14519    14519           
  Branches      2283     2285    +2     
========================================
  Hits          7563     7563           
  Misses        6106     6106           
  Partials       850      850           
Impacted Files Coverage Δ
src/parts/environments-sc/ScEnvironmentCard.js 37.70% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0119e7d...f8d8852. Read the comment docs.

Copy link
Contributor

@SanketD92 SanketD92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maghirardelli maghirardelli merged commit 9c1daa4 into develop Oct 18, 2021
@maghirardelli maghirardelli deleted the delete-config-display-fix branch October 18, 2021 20:38
jxuamazon pushed a commit to jxuamazon/service-workbench-on-aws that referenced this pull request Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants