Skip to content
This repository has been archived by the owner on Dec 6, 2024. It is now read-only.

fix: remove test target from infrastructure tests as it is reserved for unit tests #756

Merged
merged 2 commits into from
Oct 15, 2021

Conversation

jn1119
Copy link
Contributor

@jn1119 jn1119 commented Oct 15, 2021

Issue #, if available: N/A

Description of changes:

Testing done:

  1. Verified that cicd pipeline works didn't fail due to the same unit-test error. It still fails for me due some other error which I am verifying. I am determining if it is related to 4.0.0 release or not

edit: the tests passed, so I am planning on pushing this code and verifying in our common account if CICD pipeline was successful

AS review ticket id:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jn1119 jn1119 requested review from nguyen102 and SanketD92 October 15, 2021 15:15
@jn1119 jn1119 self-assigned this Oct 15, 2021
@jn1119 jn1119 requested a review from a team as a code owner October 15, 2021 15:15
@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #756 (efac8a5) into develop (b9bc283) will decrease coverage by 12.34%.
The diff coverage is n/a.

❗ Current head efac8a5 differs from pull request most recent head c3f374a. Consider uploading reports for the commit c3f374a to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##           develop     #756       +/-   ##
============================================
- Coverage    52.09%   39.74%   -12.35%     
============================================
  Files          272       75      -197     
  Lines        14519     3558    -10961     
  Branches      2283      575     -1708     
============================================
- Hits          7563     1414     -6149     
+ Misses        6106     1861     -4245     
+ Partials       850      283      -567     
Impacted Files Coverage Δ
lib/user/user-authz-service.js 24.07% <0.00%> (-52.40%) ⬇️
lib/helpers/utils.js 21.21% <0.00%> (-43.75%) ⬇️
src/models/users/User.js 12.12% <0.00%> (-40.71%) ⬇️
src/models/users/UsersStore.js 36.70% <0.00%> (-7.46%) ⬇️
lib/user/user-service.js 64.93% <0.00%> (-2.18%) ⬇️
src/parts/studies/StudiesPage.js
src/parts/projects/ProjectConfigure.js
lib/helpers/iam/study-policy.js
src/helpers/cfn-service.js
lib/utils/attribute-value.js
... and 193 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9bc283...c3f374a. Read the comment docs.

@jn1119 jn1119 merged commit 4adb965 into awslabs:develop Oct 15, 2021
jxuamazon pushed a commit to jxuamazon/service-workbench-on-aws that referenced this pull request Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants