Skip to content
This repository has been archived by the owner on Dec 6, 2024. It is now read-only.

fix: add label to stop e2e tests timing out #688

Merged
merged 1 commit into from
Aug 31, 2021
Merged

Conversation

maghirardelli
Copy link
Contributor

Issue #, if available:

Description of changes: the e2e test timed out I think because it didn't wait for the proper button to render before it tried to find the button to click. I now named the button so it should wait for that button to render before it checks it's contents. This did not timeout in my local or dev tests so I hope it works in the pipeline so everything can get to mainline

Checklist:

  • Have you successfully deployed to an AWS account with your changes?
  • Have you successfully tested with your changes locally?

AS review ticket id:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@maghirardelli maghirardelli self-assigned this Aug 31, 2021
@maghirardelli maghirardelli requested a review from a team as a code owner August 31, 2021 16:32
@codecov
Copy link

codecov bot commented Aug 31, 2021

Codecov Report

Merging #688 (53e771c) into develop (9c74ac7) will not change coverage.
The diff coverage is n/a.

❗ Current head 53e771c differs from pull request most recent head b9593d7. Consider uploading reports for the commit b9593d7 to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #688   +/-   ##
========================================
  Coverage    49.15%   49.15%           
========================================
  Files          252      252           
  Lines        12795    12795           
  Branches      2062     2062           
========================================
  Hits          6289     6289           
  Misses        5692     5692           
  Partials       814      814           
Impacted Files Coverage Δ
...ironment-types/env-type-editor-steps/ConfigStep.js 1.72% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c74ac7...b9593d7. Read the comment docs.

@maghirardelli maghirardelli merged commit ff0b4cc into develop Aug 31, 2021
@maghirardelli maghirardelli deleted the e2etimeout branch August 31, 2021 17:54
maghirardelli added a commit that referenced this pull request Sep 1, 2021
jxuamazon pushed a commit to jxuamazon/service-workbench-on-aws that referenced this pull request Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants