This repository has been archived by the owner on Dec 6, 2024. It is now read-only.
fix: end2end test terminates existing workspaces from past end-to-end tests #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #685 +/- ##
===========================================
+ Coverage 49.15% 51.93% +2.78%
===========================================
Files 252 188 -64
Lines 12795 9930 -2865
Branches 2062 1556 -506
===========================================
- Hits 6289 5157 -1132
+ Misses 5692 4212 -1480
+ Partials 814 561 -253
Continue to review full report at Codecov.
|
nguyen102
approved these changes
Aug 31, 2021
maghirardelli
added a commit
that referenced
this pull request
Sep 1, 2021
This reverts commit 9c74ac7.
jxuamazon
pushed a commit
to jxuamazon/service-workbench-on-aws
that referenced
this pull request
Feb 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes: my code change from last week delayed the rendering of the terminate buttons in the workspaces page. Thus, the end-to-end tests did not wait and terminate those instances. Now, the tests will wait until those buttons appear or until the message that there are no workspaces (and thus none to terminate) to try to terminate old testing workspaces.
Checklist:
AS review ticket id:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.