This repository has been archived by the owner on Dec 6, 2024. It is now read-only.
feat: display Configuration Name and Instance Type on Workspace details card #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #669 +/- ##
===========================================
- Coverage 49.20% 49.11% -0.10%
===========================================
Files 246 248 +2
Lines 12665 12759 +94
Branches 2023 2041 +18
===========================================
+ Hits 6232 6266 +34
- Misses 5629 5683 +54
- Partials 804 810 +6
Continue to review full report at Codecov.
|
|
We need to add these two fields to the env type config cards for selection before launching workspace as well. |
|
Display for the select configuration cards: |
nguyen102
reviewed
Aug 23, 2021
addons/addon-base-raas-ui/packages/base-raas-ui/src/parts/environments-sc/ScEnvironmentCard.js
Outdated
Show resolved
Hide resolved
addons/addon-base-raas-ui/packages/base-raas-ui/src/parts/environments-sc/ScEnvironmentCard.js
Outdated
Show resolved
Hide resolved
addons/addon-base-raas-ui/packages/base-raas-ui/src/parts/environments-sc/ScEnvironmentCard.js
Outdated
Show resolved
Hide resolved
...-raas-ui/packages/base-raas-ui/src/parts/environments-sc/__tests__/ScEnvironmentCard.test.js
Outdated
Show resolved
Hide resolved
jxuamazon
pushed a commit
to jxuamazon/service-workbench-on-aws
that referenced
this pull request
Feb 15, 2022
…ls card (awslabs#669) feat: display Configuration Name and Instance Type on Workspace details card and when selecting configuration to create a new workspace
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: GALI-284
Description of changes: Added two new rows at the bottom of the details table for the Workspace cards that display the Configuration Name and Instance Type of the workspace for researchers to better understand the capacity of the workspace:
Checklist:
AS review ticket id:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.