Skip to content
This repository has been archived by the owner on Dec 6, 2024. It is now read-only.

docs: IDP configuration guide #569

Merged
merged 9 commits into from
Jul 12, 2021
Merged

Conversation

shyogesh-sw
Copy link
Contributor

Issue #, if available: https://sim.amazon.com/issues/GALI-811

Description of changes: IDP topic has been rewritten and added to the SWB configuration guide.

Checklist:

  • Have you successfully deployed to an AWS account with your changes?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully tested with your changes locally?
  • If new dependencies have been added, have they been pinned to specific versions?
  • Is this change also required on the AWS Solution version?
  • Have you updated openapi.yaml if you made updates to API definition (including add, delete or update parameter and request data schema)?
  • If you had to run manual tests, have you considered automating those tests by adding them to end-to-end tests?

AS review ticket id:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@shyogesh-sw shyogesh-sw requested a review from a team as a code owner July 12, 2021 20:42
Copy link
Contributor

@SanketD92 SanketD92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #569 (50470dc) into develop (9243d75) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #569   +/-   ##
========================================
  Coverage    50.29%   50.29%           
========================================
  Files          231      231           
  Lines        11770    11770           
  Branches      1855     1855           
========================================
  Hits          5920     5920           
  Misses        5146     5146           
  Partials       704      704           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9243d75...50470dc. Read the comment docs.

@shyogesh-sw shyogesh-sw merged commit 406c656 into awslabs:develop Jul 12, 2021
jxuamazon pushed a commit to jxuamazon/service-workbench-on-aws that referenced this pull request Feb 15, 2022
* <docs: added hyperlinks in packer readme>

* Revert "<docs: added hyperlinks in packer readme>"

This reverts commit 501b7de.

* docs: idp guide
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants