This repository has been archived by the owner on Dec 6, 2024. It is now read-only.
chore: Enable server side encryption on prepare master and edge lambda bucket #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures that root application roles cannot be used to modify themselves and they are just used for creating and modifying file system roles which have a permission boundary
nguyen102
approved these changes
Jun 9, 2021
Codecov Report
@@ Coverage Diff @@
## develop #521 +/- ##
========================================
Coverage 49.04% 49.04%
========================================
Files 243 243
Lines 12503 12503
Branches 2012 2012
========================================
Hits 6132 6132
Misses 5564 5564
Partials 807 807 Continue to review full report at Codecov.
|
ahl27
added a commit
that referenced
this pull request
Jun 11, 2021
* feature: updated UI for AWS accounts page with cards instead of a list box. * feature: added API calls to update AWS Account, added functionality to check permissions status and update with DB table on backend * feat: adds filter buttons for accounts as well as code cleanup and general UX improvements. * fix: fixed budget buttons on account cards to correctly direct to the budget page * fix: cleaned up code, added unit test, added entry to openapi.yaml * fix: removed unused file * fix: made some buttons look better * fix: added unit test to increase codecov and fixed a minor bug in AwsAccountsStore * chore: docs dependency fix (#505) * chore(deps): bump dns-packet from 1.3.1 to 1.3.4 in /docs (#507) * chore(deps): bump dns-packet from 1.3.1 to 1.3.4 in /docs Bumps [dns-packet](https://github.com/mafintosh/dns-packet) from 1.3.1 to 1.3.4. - [Release notes](https://github.com/mafintosh/dns-packet/releases) - [Changelog](https://github.com/mafintosh/dns-packet/blob/master/CHANGELOG.md) - [Commits](mafintosh/dns-packet@v1.3.1...v1.3.4) Signed-off-by: dependabot[bot] <support@github.com> * fix: trigger build * feat: Add warning that internal authentication shouldn't be used in production (#506) * feat: Encrypt s3 buckets for EMR log bucket and CICD Artifact bucket (#508) * chore: Disable EBS volume for storage gateway (#511) Co-authored-by: Tim Nguyen <thingut@amazon.com> * fix: changes suggested by Yanyu in CR * fix: minor change to openapi.yml * fix: removed unneccessary script * fix: removed reliance on undefined value for needsPermissionUpdate * fix: changed NEW to ONBOARDME for better clarity * Update settings.json * Update settings.json * removed confusing half-implemented function and replaced with placeholder * chore: Add encryption to CICD SNS topic (#512) Co-authored-by: Tim Nguyen <thingut@amazon.com> * fix: Allow sagemaker to have the proper IAM permission to autostop itself (#515) * chore: Enable access logging for env-type-configs bucket (#520) * chore: Enable server side encryption on prepare master and edge lambda bucket (#521) * fix: Corrected Spark defaults to fix read/write functionality from Spark (#526) Co-authored-by: Yanyu Zheng <yz2690@columbia.edu> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tim Nguyen <nguyen102@users.noreply.github.com> Co-authored-by: Tim Nguyen <thingut@amazon.com> Co-authored-by: Jeet <68876606+jn1119@users.noreply.github.com>
ahl27
pushed a commit
that referenced
this pull request
Jun 11, 2021
ahl27
pushed a commit
to ahl27/service-workbench-on-aws
that referenced
this pull request
Jun 11, 2021
jn1119
added a commit
that referenced
this pull request
Jun 14, 2021
manikandan-thangavelu-rl
pushed a commit
to RLOpenCatalyst/service-workbench-on-aws
that referenced
this pull request
Jun 14, 2021
manikandan-thangavelu-rl
added a commit
to RLOpenCatalyst/service-workbench-on-aws
that referenced
this pull request
Jun 14, 2021
…ge lambda bucket (awslabs#521)" This reverts commit 5e2701c.
jxuamazon
pushed a commit
to jxuamazon/service-workbench-on-aws
that referenced
this pull request
Feb 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: V377389653
Description of changes: This is a recommendation based on a AppSec/PenTest finding where it was recommended that we encrypt these buckets.
Testing done:
Checklist:
AS review ticket id:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.