Skip to content
This repository has been archived by the owner on Dec 6, 2024. It is now read-only.

chore: disable gcov & codecov fine tune #460

Merged
merged 1 commit into from
Apr 23, 2021
Merged

Conversation

SanketD92
Copy link
Contributor

Issue #, if available:
GALI-802

Description of changes:
Run CodeCov only against PRs. Drop threshold set to 0.1%

Checklist:

  • Have you successfully deployed to an AWS account with your changes?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully tested with your changes locally?
  • Have you updated openapi.yaml if you made updates to API definition (including add, delete or update parameter and request data schema)?
  • If you had to run manual tests, have you considered automating those tests by adding them to end-to-end tests?

AS review ticket id:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@SanketD92 SanketD92 requested a review from a team as a code owner April 23, 2021 14:10
@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2021

Codecov Report

Merging #460 (43f8d6d) into develop (03afe0e) will increase coverage by 1.04%.
The diff coverage is n/a.

❗ Current head 43f8d6d differs from pull request most recent head b64295a. Consider uploading reports for the commit b64295a to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #460      +/-   ##
===========================================
+ Coverage    48.76%   49.81%   +1.04%     
===========================================
  Files          493      242     -251     
  Lines        22909    10297   -12612     
  Branches      3457     1438    -2019     
===========================================
- Hits         11171     5129    -6042     
+ Misses       10097     4351    -5746     
+ Partials      1641      817     -824     
Impacted Files Coverage Δ
...e-raas-ui/src/models/forms/CreateAwsAccountForm.js
...raas-services/lib/user/helpers/user-authz-utils.js
...aas-ui/packages/base-raas-ui/src/helpers/crypto.js
...kages/base-raas-ui/src/helpers/externalCostUtil.js
...-raas-ui/packages/base-raas-ui/src/helpers/form.js
...base-ui/src/models/constants/local-storage-keys.js
...ges/base-raas-ui/src/models/aws-accounts/Budget.js
...mbdas/authentication-layer-handler/handler-impl.js
...ment/lib/steps/create-service-catalog-portfolio.js
...service-catalog/environment-config-vars-service.js
... and 241 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03afe0e...b64295a. Read the comment docs.

@github-actions github-actions bot added size/s and removed size/m labels Apr 23, 2021
@SanketD92 SanketD92 force-pushed the chore-codecov-fine-tune branch from 60a7c21 to 235b4c7 Compare April 23, 2021 20:56
@SanketD92 SanketD92 merged commit 9b30e4e into develop Apr 23, 2021
@SanketD92 SanketD92 deleted the chore-codecov-fine-tune branch April 23, 2021 21:44
jxuamazon pushed a commit to jxuamazon/service-workbench-on-aws that referenced this pull request Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants