Skip to content
This repository has been archived by the owner on Dec 6, 2024. It is now read-only.

fix: Update workspace name reg exp and workspace config tags reg exp #452

Merged
merged 4 commits into from
Apr 22, 2021

Conversation

nguyen102
Copy link
Contributor

@nguyen102 nguyen102 commented Apr 20, 2021

Issue #, if available:
#439
Description of changes:

  • Allows user to import Workspaces that have spaces in its name
  • Allows user to add Workspace configuration with variables, for example ${indexId}

Checklist:

  • Have you successfully deployed to an AWS account with your changes?
  • Have you successfully ran unit tests and manual tests with your changes locally?
  • Have you written new tests for your core changes, as applicable?

AS review ticket id:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@nguyen102 nguyen102 marked this pull request as ready for review April 20, 2021 19:39
@nguyen102 nguyen102 requested a review from a team as a code owner April 20, 2021 19:39
Copy link
Contributor

@Bingjiling Bingjiling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nguyen102 nguyen102 merged commit f9b7d62 into awslabs:develop Apr 22, 2021
@nguyen102 nguyen102 deleted the workspace-validation branch August 23, 2021 14:48
jxuamazon pushed a commit to jxuamazon/service-workbench-on-aws that referenced this pull request Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants