fix: e2etest cleanup

awslabs · Nov 13, 2023 · 7f17e2f · 7f17e2f
1 parent 9567894
commit 7f17e2f
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 57 deletions.
diff --git a/main/end-to-end-tests/checkConnection.js b/main/end-to-end-tests/checkConnection.js
diff --git a/main/end-to-end-tests/cypress/e2e/appstream-egress-enabled/workspaces.cy.js b/main/end-to-end-tests/cypress/e2e/appstream-egress-enabled/workspaces.cy.js
@@ -27,9 +27,6 @@ describe('Launch new workspaces', () => {
     navigateToWorkspaces();
     terminateWorkspaces();
   });
-  after(() => {
-    terminateWorkspaces();
-  });
 
   let expectedNumberOfNewlyOpenBrowserWindows = 0;
 
@@ -50,6 +47,8 @@ describe('Launch new workspaces', () => {
     cy.window()
       .its('open')
       .should('have.callCount', expectedNumberOfNewlyOpenBrowserWindows);
+
+    terminateWorkspaces();
   });
 
   function checkWindows(workspaceName) {
@@ -136,14 +135,4 @@ describe('Launch new workspaces', () => {
       .find('[data-testid=sc-environment-generate-url-button]', { timeout: 60000 })
       .click();
   }
-
-  /**
-   * This test checks that the connection library we're using works correctly.
-   */
-  it('checkConnection should work correctly', () => {
-    // 8.8.8.8 is Google's DNS server
-    cy.exec(`node checkConnection.js 8.8.8.8 443`)
-      .its('code')
-      .should('equal', 0);
-  });
 });
diff --git a/main/end-to-end-tests/package-lock.json b/main/end-to-end-tests/package-lock.json
diff --git a/main/end-to-end-tests/package.json b/main/end-to-end-tests/package.json
@@ -41,7 +41,6 @@
     "lodash": "^4.17.21",
     "prettier": "^1.19.1",
     "pretty-quick": "^1.11.1",
-    "tcp-ping": "^0.1.1",
     "eslint-plugin-react-hooks": "^4.3.0",
     "eslint-plugin-react": "^7.28.0"
   },

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml