Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix support for nested modules in archives #751

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

dgraeber
Copy link
Contributor

@dgraeber dgraeber commented Dec 2, 2024

Issue #, if available:
#749

Description of changes:
SF was trying to enforce modules to be at the root within an archive. This change allows nested modules with backward compatibility support.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dgraeber dgraeber requested a review from a team December 2, 2024 15:24
@@ -90,17 +89,10 @@ def _process_archive(archive_name: str, response: Response, extracted_dir: str)
archive_file.write(response.content)

extracted_dir_path = os.path.join(parent_dir, extracted_dir)
embedded_dir = _extract_archive(archive_name, extracted_dir_path)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is the only caller should we remove the return parameter?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to leave it for now for continuity sake? There are no assigned / unused variables.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't need to be done for now, could be clean-up in the future.

@dgraeber dgraeber merged commit f15f617 into awslabs:main Dec 2, 2024
6 checks passed
@dgraeber dgraeber deleted the fix/httpsfetch branch December 2, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants