-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add constraint to resolution of requirements-dev.txt #622
chore: add constraint to resolution of requirements-dev.txt #622
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure what the benefit of the PR is (just looking for a reason to do this....not opposed to it otherwise)
Mainly just to keep the requirements consistent. A minor concern is that in our workflow, we first install from This, however, is quite a minor concern. The main thing is just keep our dependencies clean and consistent. |
Ok...just remove the change to the docs/requirements-docs.txt -- that is really only for readthedocs. I like this change for the requirments-dev.txt though....good catch! I will look to remove the sphinx references from the requirements-dev.txt also...that is no longer needed (I believe) |
This reverts commit dfef901.
Description of changes:
Our
requirements-dev.txt
resolution doesn't take into account our production dependencies.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.