Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add constraint to resolution of requirements-dev.txt #622

Merged
merged 4 commits into from
Jun 13, 2024
Merged

chore: add constraint to resolution of requirements-dev.txt #622

merged 4 commits into from
Jun 13, 2024

Conversation

LeonLuttenberger
Copy link
Contributor

@LeonLuttenberger LeonLuttenberger commented Jun 12, 2024

Description of changes:
Our requirements-dev.txt resolution doesn't take into account our production dependencies.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@LeonLuttenberger LeonLuttenberger marked this pull request as ready for review June 12, 2024 17:08
Copy link
Contributor

@dgraeber dgraeber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what the benefit of the PR is (just looking for a reason to do this....not opposed to it otherwise)

docs/requirements-docs.txt Outdated Show resolved Hide resolved
@LeonLuttenberger
Copy link
Contributor Author

I am not sure what the benefit of the PR is (just looking for a reason to do this....not opposed to it otherwise)

Mainly just to keep the requirements consistent. A minor concern is that in our workflow, we first install from requirement.txt and then from requirements-dev.txt. In the latter, we have outdated versions of certain packages that overlap. So our workflows end up with outdated versions of certain packages, instead of testing on the one we specify in requirement.txt. Dependabot doesn't seem to keep this in line either, although that could change now that the pip-compile command includes the constraints argument.

This, however, is quite a minor concern. The main thing is just keep our dependencies clean and consistent.

@dgraeber
Copy link
Contributor

I am not sure what the benefit of the PR is (just looking for a reason to do this....not opposed to it otherwise)

Mainly just to keep the requirements consistent. A minor concern is that in our workflow, we first install from requirement.txt and then from requirements-dev.txt. In the latter, we have outdated versions of certain packages that overlap. So our workflows end up with outdated versions of certain packages, instead of testing on the one we specify in requirement.txt. Dependabot doesn't seem to keep this in line either, although that could change now that the pip-compile command includes the constraints argument.

This, however, is quite a minor concern. The main thing is just keep our dependencies clean and consistent.

Ok...just remove the change to the docs/requirements-docs.txt -- that is really only for readthedocs. I like this change for the requirments-dev.txt though....good catch! I will look to remove the sphinx references from the requirements-dev.txt also...that is no longer needed (I believe)

@dgraeber dgraeber merged commit 88cef54 into awslabs:main Jun 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants