adding support for module manifest schema #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seedfarmer/mgmt/build_info.py
Outdated
| elif "module" == type.lower(): | ||
| return ModuleManifest.model_json_schema() | ||
| else: | ||
| return None |
There was a problem hiding this comment.
Minor nitpick: We could just raise an error here, and that way wouldn't need to change the return type of the function.
seedfarmer/cli_groups/_list_group.py
Outdated
Comment on lines
795
to
796
| if type not in ["deployment", "module"]: | ||
| print_bolded(message="Only 'deployment' or 'module' can be passed in", color="yellow") |
There was a problem hiding this comment.
We can use click.Choice to perform this validation for us.
| @@ -67,4 +67,4 @@ def test_get_build_params(mocker): | |||
| @pytest.mark.mgmt | |||
| @pytest.mark.mgmt_build_info | |||
| def test_validate_group_parameters(): | |||
| bi.get_manifest_schema() | |||
There was a problem hiding this comment.
Do we maybe want another unit test here for type="module"?
LeonLuttenberger
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#612
Description of changes:
Adding support to fetch only the module manifest schema
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.