Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Readme navigation fix for roadmap link #5

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

twosdai
Copy link
Contributor

@twosdai twosdai commented Feb 29, 2024

Fixes the roadmap navigation link inside of the readme to properly point to the roadmap of the SBT readme rather than the CDK.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

@twosdai twosdai changed the title Readme navigation fix for roadmap link docs: Readme navigation fix for roadmap link Feb 29, 2024
@twosdai
Copy link
Contributor Author

twosdai commented Feb 29, 2024

Hey I saw that the readme for the current release incorrectly points to the CDK's roadmap, I created a quick PR in order to fix it. I was confused while reading through the readme about the SBT's roadmap and it seemed CDK specific only to realize that the readme was pointing to the wrong location.

I noticed that you have a naming convention for PR's, I saw that within the link: https://www.conventionalcommits.org/en/v1.0.0/
the title docs is used which I think fits for this, I could also see it as a fix. Let me know if you need me to change anything.

@tobuck-aws I saw that you commited to the repo already, I am not sure if you are the right person to ping regarding getting this reviewed and merged.

@tobuck-aws
Copy link
Contributor

tobuck-aws commented Feb 29, 2024

@twosdai, thanks, we appreciate the contribution! We are using conventional commits, but as you mentioned, docs: is acceptable. I think I missed some configuration on our side. I'll get that fixed before I merge this.

@tobuck-aws tobuck-aws merged commit 3945b18 into awslabs:main Feb 29, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants