feat: Expose CoreAppPlane JobRunner codebuild IAM role #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: github-actions <github-actions@github.com>
…nto ps-release-fix
Signed-off-by: github-actions <github-actions@github.com>
…nto ps-release-fix
suhussai
reviewed
May 1, 2024
| @@ -200,7 +200,53 @@ describe('CoreApplicationPlane', () => { | |||
| ), | |||
| }, | |||
| }); | |||
| cdk.Aspects.of(app).add(new AwsSolutionsChecks()); | |||
|
@ujwalbukka , is this still needed? |
We don't need this, closing it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Reason for this change
We need this because if codebuild project is provisioning a resource for an AWS service. The resource policy of a AWS service will expect the codebuild project role has permissions to do the needful.
For example, the if codebuild project is creating an index in OpenSearch serverless then data access policy of OpenSearch serverless expects the codebuild project role is mentioned as principal which has access to create index.
Description of changes
Created a public readonly map which has jobname and jobRunnerRoleArn
Description of how you validated changes
added unit test
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.