-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build system #331
Merged
Merged
Fix build system #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
hughcars
commented
Feb 5, 2025
•
edited
Loading
edited
- Resolve issue where mpich on ubuntu 24 has a bug where the world size is always 1
- Adds an MPI test fixture in the builds
- Rolls back the os runner to Ubuntu 22 if mpich is installed
- Updates armpl and enables in the aarch64 build
- Changes the gnu compiler selection logic to always pull the most recent version available on the image
- Generate expanded pairs testing matrices to account for arm ubuntu builds, and macos builds
- Arm builds use ubuntu 22 runners due to instability in ubuntu 24 runners (actions/checkout@v4 SIGSEGV (exit code 139) in ubuntu-24.04-arm actions/partner-runner-images#47 etc.) causing non-deterministic ci fails independent of Palace.
…i in aarch64 and spack build.
4c7c0ec
to
e25bb4a
Compare
…, delete emulated arm build
…bug, and check armpl on macos builds
d789154
to
60ca8ea
Compare
9c0f95d
to
6dfc3e0
Compare
5933994
to
6c09404
Compare
6c09404
to
755922a
Compare
755922a
to
a8303f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.