Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(PR): doc update and code generation issue #958

Merged
merged 4 commits into from
Feb 13, 2025
Merged

chore(PR): doc update and code generation issue #958

merged 4 commits into from
Feb 13, 2025

Conversation

krokoko
Copy link
Collaborator

@krokoko krokoko commented Feb 12, 2025 •
edited
Loading

Fixes #

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

@krokoko krokoko marked this pull request as ready for review February 12, 2025 21:25
@krokoko krokoko requested a review from a team as a code owner February 12, 2025 21:26
MichaelWalker-git
MichaelWalker-git approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@MichaelWalker-git MichaelWalker-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krokoko krokoko merged commit f3908be into awslabs:main Feb 13, 2025
4 of 6 checks passed
@krokoko krokoko deleted the doc_update_feb12 branch February 17, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelWalker-git MichaelWalker-git MichaelWalker-git approved these changes

@alexa-perlov alexa-perlov alexa-perlov approved these changes

@dineshSajwan dineshSajwan Awaiting requested review from dineshSajwan dineshSajwan is a code owner automatically assigned from awslabs/generative-ai-cdk-constructs-maintainers

@aws-rafams aws-rafams Awaiting requested review from aws-rafams aws-rafams is a code owner automatically assigned from awslabs/generative-ai-cdk-constructs-maintainers

Assignees
No one assigned
Labels
distinguished-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@krokoko @MichaelWalker-git @alexa-perlov @emerging-tech-cdk-constructs-bot