Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade projen and jsii #879

Merged
merged 9 commits into from
Jan 13, 2025
Merged

Conversation

krokoko
Copy link
Collaborator

@krokoko krokoko commented Jan 6, 2025

Fixes #

  • Upgrade Projen to version 0.91.5
  • Upgrade JSII to v5.6.0, which is the default version in Projen since v0.91.0
  • Update the license plugin header to this one. Previous one is not compatible with eslint v9 and seems to not be maintained anymore. Tested to make sure it works as expected.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

@krokoko krokoko marked this pull request as ready for review January 7, 2025 15:54
@krokoko krokoko requested a review from a team as a code owner January 7, 2025 15:54
Copy link
Contributor

@MichaelWalker-git MichaelWalker-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

mergify bot commented Jan 7, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #879 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (detail: You're not authorized to push to this branch. Visit https://docs.github.com/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/about-protected-branches for more information.)

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

Signed-off-by: Alain Krok <alkrok@amazon.com>
@krokoko krokoko merged commit 2c64058 into awslabs:main Jan 13, 2025
16 checks passed
@krokoko krokoko deleted the projen_upgrade branch February 10, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants