chore(sg): remove default value for volumesize property #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #274 +/- ##
==========================================
- Coverage 94.93% 94.93% -0.01%
==========================================
Files 35 35
Lines 8464 8462 -2
Branches 244 243 -1
==========================================
- Hits 8035 8033 -2
Misses 429 429 ☔ View full report in Codecov by Sentry. |
dineshSajwan
approved these changes
Feb 20, 2024
laithalsaadoon
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Currently, we force a default value for the volumesizeingb property in the custom sg endpoint. However, for some instance types, this is not supported and fails at deploy time. We now use the value passed through props only if provided
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.