Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eula): expose the eula property for SageMaker JumpStart model deployment #257

Merged
merged 17 commits into from
Feb 28, 2024

Conversation

krokoko
Copy link
Collaborator

@krokoko krokoko commented Feb 14, 2024

Fixes #

  • Upgrade cdk to earliest version exposing the new property for model deployment (this commit introduced in v2.122.0)
  • fail cdk synth if the property is not explicitly set to true by the user
  • expose new property for SageMaker JumpStart model deployment : accept_eula Specifies agreement to the model end-user license agreement (EULA). The AcceptEula value must be explicitly defined as True in order to accept the EULA that the model requires. The user is responsible for reviewing and complying with any applicable license terms and making sure they are acceptable for their use case before downloading or using a model.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 95.91%. Comparing base (fd6dc16) to head (e041b58).

Files Patch % Lines
...ployment-sagemaker/jumpstart-sagemaker-endpoint.ts 78.57% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #257      +/-   ##
==========================================
+ Coverage   95.23%   95.91%   +0.67%     
==========================================
  Files          36       36              
  Lines        9074     9089      +15     
  Branches      259      280      +21     
==========================================
+ Hits         8642     8718      +76     
+ Misses        432      371      -61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hvital
hvital previously approved these changes Feb 14, 2024
@krokoko krokoko marked this pull request as draft February 20, 2024 16:45
@krokoko krokoko marked this pull request as ready for review February 27, 2024 00:51
@krokoko krokoko enabled auto-merge (squash) February 27, 2024 14:38
Copy link
Contributor

@dineshSajwan dineshSajwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krokoko krokoko merged commit ef890d6 into awslabs:main Feb 28, 2024
11 of 13 checks passed
@krokoko krokoko deleted the feat/eula branch February 28, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants