Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (Encrypt scrap buckets created for integration tests) #314

Merged
merged 2 commits into from
Aug 9, 2021
Merged

Conversation

biffgaut
Copy link
Contributor

@biffgaut biffgaut commented Aug 7, 2021

Issue #, if available: Issue 305

Description of changes:
AWS scanning tools are flagging scrap buckets in integration cloudformation templates for not being encrypted

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Closes 305

@biffgaut biffgaut linked an issue Aug 7, 2021 that may be closed by this pull request
@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: codebuildgithubautobuildPro-fkVQbXRiQi6A
  • Commit ID: f57a048
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@@ -0,0 +1,30 @@
export constructs="
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this list for?

for construct in $constructs; do
cd $deployment_dir/source/patterns/@aws-solutions-constructs/$construct
npm run jsii && npm run build
cdk-integ
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use npm run integ ?

@biffgaut biffgaut merged commit 1aa4e9c into main Aug 9, 2021
@biffgaut biffgaut deleted the Issue305 branch August 9, 2021 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Encrypt scrap buckets created for integration tests
3 participants