feat(aws-eventbridge-kinesisstreams) created new construct #311
Conversation
…le-kinesisstreams
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| @@ -0,0 +1,105 @@ | |||
| /** | |||
There was a problem hiding this comment.
Architecture diagram is CloudWatch events rule, not EventBridge
|
|
||
| This AWS Solutions Construct implements an Amazon CloudWatch Events rule to send data to an Amazon Kinesis Data Stream | ||
| This AWS Solutions Construct implements an Amazon CloudWatch Events rule to send data to an Amazon Kinesis Data Streams |
There was a problem hiding this comment.
This should still be data stream, it's not referring to the service but a single resource ("an Amazon Kinesis data stream", and the lower case "d" and "s" is intentional and correct)
Handy site for service/resource names is here.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| @@ -24,7 +24,7 @@ | |||
| | Typescript|`@aws-solutions-constructs/aws-events-rule-kinesisstreams`| | |||
| | Java|`software.amazon.awsconstructs.services.eventsrulekinesisstreams`| | |||
|
|
|||
| This AWS Solutions Construct implements an Amazon CloudWatch Events rule to send data to an Amazon Kinesis Data Streams | |||
| This AWS Solutions Construct implements an Amazon CloudWatch Events rule to send data to an Amazon Kinesis Data Stream. | |||
There was a problem hiding this comment.
Pretty sure in my comment I said the lower case d and s in Data Stream were intentional and correct...
Amazon Kinesis data stream
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue #289, if available:
Description of changes:
-Created new construct for aws-eventbridge-kinesisstreams
-Created wrapper in aws-events-rule-kinesisstreams to support new construct
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.