Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws-cloudfront-mediastore): new aws-cloudfront-mediastore pattern implementation #106

Closed
wants to merge 1 commit into from

Conversation

beomseoklee
Copy link
Contributor

Issue #, if available: #104

Description of changes:
This PR introduces a new pattern which can be used by live streaming solutions. The pattern creates an Amazon CloudFront distribution whose origin is an AWS Elemental MediaStore container.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@beomseoklee beomseoklee requested a review from hnishar as a code owner December 3, 2020 00:23
@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: codebuildgithubautobuildPro-rp7jMDIK1wBN
  • Commit ID: 5ebf8e9
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@beomseoklee
Copy link
Contributor Author

To build source/tools/cdk-integ-tools, it seems like the latest yargs returns argv as string[] or number[] so the CodeBuild failed. If you are OK, I'll update cdk-integ.ts file.

Currently,

const tests = await new IntegrationTests('test').fromCliArgs(argv._);

And update would be

const tests = await new IntegrationTests('test').fromCliArgs(<string[]>argv._);

Let me know your thought.

@beomseoklee beomseoklee closed this Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants