Skip to content

Commit

Permalink
Address cfn_nag issues
Browse files Browse the repository at this point in the history
  • Loading branch information
biffgaut committed Oct 20, 2021
1 parent 4dbfea3 commit 4a5adb9
Show file tree
Hide file tree
Showing 14 changed files with 849 additions and 154 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Here is a minimal deployable pattern definition in Typescript:
const certificate = acm.Certificate.fromCertificateArn(
scope,
'existing-cert',
"arn:aws:acm:us-east-1:123456789012:certificate/12345678-1234-1234-1234-123456789012"
"arn:aws:acm:us-east-1:123456789012:certificate/11112222-3333-1234-1234-123456789012"
);
const props: AlbToLambdaProps = {
lambdaFunctionProps: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ function GetFakeCertificate(scope: Construct, id: string): acm.ICertificate {
return acm.Certificate.fromCertificateArn(
scope,
id,
"arn:aws:acm:us-east-1:123456789012:certificate/12345678-1234-1234-1234-1234567890AB"
"arn:aws:acm:us-east-1:123456789012:certificate/11112222-3333-1234-1234-123456789012"
);
}

Expand Down Expand Up @@ -677,7 +677,7 @@ test('Test providing certificateArns is an error', () => {
handler: 'index.handler'
},
listenerProps: {
certificateArns: [' arn:aws:acm:us-east-1:123456789012:certificate/12345678-1234-1234-1234-123456789012']
certificateArns: [' arn:aws:acm:us-east-1:123456789012:certificate/11112222-3333-1234-1234-123456789012']
},
targetProps: {
targetGroupName: 'different-name'
Expand Down
Loading

0 comments on commit 4a5adb9

Please sign in to comment.