Update chagelog and docstrings #109
Merged
+45
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29b1c94 to
ea37028
Compare
This commit updates the changelog and adds docstrings for methods `new_from_public_key`, `sign`, and `verify` for `KmsKey`s to specifically highlight the need to call these methods from a Tokio runtime. Signed-off-by: Mark Kirichenko <mkirich@amazon.de>
ea37028 to
76db9ab
Compare
eugkoira
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR updates the changelog and adds docstrings for methods
new_from_public_key,sign, andverifyforKmsKeys to specifically highlight the need to call these methods from a Tokio runtime.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.