Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick up s2n_cleanup_thread #293

Merged
merged 5 commits into from
Oct 11, 2024
Merged

Pick up s2n_cleanup_thread #293

merged 5 commits into from
Oct 11, 2024

Conversation

TingDaoK
Copy link
Contributor

@TingDaoK TingDaoK commented Oct 11, 2024

Issue #, if available:

aws-c-auth         v0.7.30 -> v0.7.31
aws-c-cal          v0.7.4 ✓
aws-c-common       v0.9.28 ✓
aws-c-compression  v0.2.19 ✓
aws-c-event-stream v0.4.3 ✓
aws-c-http         v0.8.9 -> v0.8.10
aws-c-io           v0.14.18 -> v0.14.19
aws-c-sdkutils     v0.1.19 ✓
aws-checksums      v0.1.19 -> v0.1.20
s2n                v1.5.2 -> v1.5.5

With a symlink to point s2n/unstable/cleanup.h to api/unstable/cleanup.h, since swift is not using CMake to build, so that it cannot use any CMake trick to check if s2n was build before or to be built together. And we are building s2n with other deps together.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@waahm7 waahm7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a aws-common-runtime/config/Readme.md to explain this hack.

@TingDaoK TingDaoK merged commit d661a55 into main Oct 11, 2024
25 checks passed
@TingDaoK TingDaoK deleted the prebuild-s2n branch October 11, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants