Retry test if httpbin.org responds with 504 Gateway Time-out #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TwistedTwigleg
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
The
testHttpUploadtests have been increasingly flaky lately, due to httpbin.org returning 504 Gateway Time-out.Description of changes:
Add 504 to the list of status codes we'll retry.
This unblocks us, but it's not a long term fix. Long term we should stop hitting httpbin.org. The httpbin project seems to be abandonded. I can't even get the latest version running locally, due to its dependencies changing out from under it.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.