Code

Better vectorization and crc64#79

Code

Merged

DmitriyMusatkin merged 119 commits intomainawslabs/aws-checksums:mainfrom better_vectorization_and_crc64awslabs/aws-checksums:better_vectorization_and_crc64Copy head branch name to clipboardSep 5, 2024

+2,031-230

Commits

Commits on Jun 22, 2023

• Added CRC32C AVX512 support.

  javazque

  committed
  c6248e0

  Copy full SHA for c6248e0

Commits on Jun 27, 2023

• Fixed routine name to indicate crc32c

  pbadari

  committed
  cf22bca

  Copy full SHA for cf22bca

• Merge pull request #1 from pbadari/avx512_support

  Show description for def3a68
  pbadari

  authored
  def3a68

  Copy full SHA for def3a68

Commits on Jul 14, 2023

• Add sse42 avx512_intrinsics support

  javazque

  committed
  375fa35

  Copy full SHA for 375fa35

• Merge pull request #2 from pbadari/sse42_avx512_intrinsics

  Show description for 9e18b50
  pbadari

  authored
  9e18b50

  Copy full SHA for 9e18b50

• Merge branch 'main' into main

  JonathanHenson

  authored
  469ef71

  Copy full SHA for 469ef71

Commits on Jul 19, 2023

• Refactoring work for the AVX512 code path. Testing shows it not quite working yet.

  JonathanHenson

  committed
  2eb5578

  Copy full SHA for 2eb5578

• Keep the naive avx512 path on for figuring out codebuild capabilities, turn it off once we know what's supported where.

  JonathanHenson

  committed
  837d5a1

  Copy full SHA for 837d5a1

• Fix build and do correct cpu feature detection.

  JonathanHenson

  committed
  2289c96

  Copy full SHA for 2289c96

• fix 32-bit builds and builds that need to work without intrinsics available.

  JonathanHenson

  committed
  ee3e5da

  Copy full SHA for ee3e5da

• Not sure how the avx512 code got called. hopefully coedebuild is just busted.

  JonathanHenson

  committed
  005ed7c

  Copy full SHA for 005ed7c

• Found why the wrong build files were being used at least.

  JonathanHenson

  committed
  39094d4

  Copy full SHA for 39094d4

• Make test pass when it passes.

  JonathanHenson

  committed
  d4ffdc1

  Copy full SHA for d4ffdc1

• Try it again.

  JonathanHenson

  committed
  bf79936

  Copy full SHA for bf79936

• fix leftover symbol collision.

  JonathanHenson

  committed
  1e24d06

  Copy full SHA for 1e24d06

• Added more compile gates and assertions.

  JonathanHenson

  committed
  907e721

  Copy full SHA for 907e721

Commits on Jul 20, 2023

• Fix osx build.

  JonathanHenson

  committed
  5ab0046

  Copy full SHA for 5ab0046

• make the bitflips uniform.

  JonathanHenson

  committed
  ca43c51

  Copy full SHA for ca43c51

• add additional runtime cpuid check and run formatter.

  JonathanHenson

  committed
  28dde8b

  Copy full SHA for 28dde8b

• work around nasty bitflipping logic.

  JonathanHenson

  committed
  a00a8e3

  Copy full SHA for a00a8e3

Commits on Jan 1, 2024

• Addressed review comments, use ternary logic instructions and optimiz… (#73)

  pbadari

  authored
  5138407

  Copy full SHA for 5138407

Commits on Jan 18, 2024

• Added crc64 implementations for arm and intel, Added some avx512 code for crc32 on intel as well.

  JonathanHenson

  committed
  2a084ac

  Copy full SHA for 2a084ac

• ran formatter.

  JonathanHenson

  committed
  3f0092f

  Copy full SHA for 3f0092f

• Updated formatter and intel compile branch.

  JonathanHenson

  committed
  d78dcb8

  Copy full SHA for d78dcb8

• lets try again.

  JonathanHenson

  committed
  1cda49a

  Copy full SHA for 1cda49a

• Manually format and updated compiler flag.

  JonathanHenson

  committed
  145267d

  Copy full SHA for 145267d

• msvc fix, more formatting, append compiler flag rather than resetting it.

  JonathanHenson

  committed
  53fb00f

  Copy full SHA for 53fb00f

• sucks to only have an arm machine to test this on.

  JonathanHenson

  committed
  1e50c18

  Copy full SHA for 1e50c18

Commits on Jan 22, 2024

• See if cleaning this up helps.

  JonathanHenson

  committed
  fca8adc

  Copy full SHA for fca8adc

Commits on Jan 23, 2024

• Merge branch 'main' into better_vectorization_and_crc64

  JonathanHenson

  authored
  dab6a82

  Copy full SHA for dab6a82

• Another clmul typo.

  JonathanHenson

  committed
  05799a5

  Copy full SHA for 05799a5

• who knows.

  JonathanHenson

  committed
  ae55f55

  Copy full SHA for ae55f55

• use the new macros

  JonathanHenson

  committed
  160d587

  Copy full SHA for 160d587

• missed one.

  JonathanHenson

  committed
  dd35f50

  Copy full SHA for dd35f50

• okay, now we're back to code being broken babuy

  JonathanHenson

  committed
  765313f

  Copy full SHA for 765313f

• there's the vl we needed.

  JonathanHenson

  committed
  166ddd9

  Copy full SHA for 166ddd9

• maybe this is all i needed.

  JonathanHenson

  committed
  9bad62d

  Copy full SHA for 9bad62d

• add sse4.2 flag back to the avx512 build for gcc8.

  JonathanHenson

  committed
  543c487

  Copy full SHA for 543c487

• windows build fixes, as well as x86 build mismatch.

  JonathanHenson

  committed
  ea25508

  Copy full SHA for ea25508

• more windows fixes and macros.

  JonathanHenson

  committed
  7b63f06

  Copy full SHA for 7b63f06

• non-standard intrinsics headers?

  JonathanHenson

  committed
  58ece21

  Copy full SHA for 58ece21

• incorrect macro syntax.

  JonathanHenson

  committed
  c6e65ea

  Copy full SHA for c6e65ea

• run formatter, fix function delcarations.

  JonathanHenson

  committed
  b074483

  Copy full SHA for b074483

• Maybe the headers i need for older compilers.

  JonathanHenson

  committed
  a3ab193

  Copy full SHA for a3ab193

• more formatter fixes.

  JonathanHenson

  committed
  d7ccb7d

  Copy full SHA for d7ccb7d

• linters.

  JonathanHenson

  committed
  4a04be9

  Copy full SHA for 4a04be9

• Magical IDE tabs are the frickin worst.

  JonathanHenson

  committed
  42f6e10

  Copy full SHA for 42f6e10

• Check 64-bit arch before assuming can use arm8.1

  JonathanHenson

  committed
  b0875b6

  Copy full SHA for b0875b6

• don't compile the crc64 arm stuff if not 64 bit.

  JonathanHenson

  committed
  3456c37

  Copy full SHA for 3456c37

• use consistent header includes.

  JonathanHenson

  committed
  032a7e5

  Copy full SHA for 032a7e5

• use an actually widely documented intrinsic.

  JonathanHenson

  committed
  5473f71

  Copy full SHA for 5473f71

• fix test build and exported symbol needed for tests.

  JonathanHenson

  committed
  d61841a

  Copy full SHA for d61841a

• Use sse2 on the msvc version when 4.2. is specified.

  JonathanHenson

  committed
  f9a7709

  Copy full SHA for f9a7709

• work around old microsoft compiler.

  JonathanHenson

  committed
  856e2a2

  Copy full SHA for 856e2a2

• add it to the correct file this time.

  JonathanHenson

  committed
  7ad72d5

  Copy full SHA for 7ad72d5

• get your types right dude.

  JonathanHenson

  committed
  0cda5eb

  Copy full SHA for 0cda5eb

• don't use the clmul version on old msvc.

  JonathanHenson

  committed
  73330e1

  Copy full SHA for 73330e1

• run formatter.

  JonathanHenson

  committed
  af2952e

  Copy full SHA for af2952e

• format again.

  JonathanHenson

  committed
  24165d7

  Copy full SHA for 24165d7

Commits on Jan 24, 2024

• Added more thorough testing to make sure all the hw accelerated branches are hit for each configuraiton.

  JonathanHenson

  committed
  bfb8600

  Copy full SHA for bfb8600

• msvc compiler errors.

  JonathanHenson

  committed
  86ca022

  Copy full SHA for 86ca022

• i think the warning was actually right.

  JonathanHenson

  committed
  82a8ed3

  Copy full SHA for 82a8ed3

• Use runtime cpu checks for arm.

  JonathanHenson

  committed
  449c8b4

  Copy full SHA for 449c8b4

• Clean up cmake.

  JonathanHenson

  committed
  995ea61

  Copy full SHA for 995ea61

• Remove unneeded glob.

  JonathanHenson

  committed
  1a3d6bd

  Copy full SHA for 1a3d6bd

• make sure tests use the testing allocator.

  JonathanHenson

  committed
  52ed9e7

  Copy full SHA for 52ed9e7

• fix windows test compiler watning.

  JonathanHenson

  committed
  a8fecf8

  Copy full SHA for a8fecf8

Commits on Jan 29, 2024

• restructured the code so the fallthroughs are less complicated.

  JonathanHenson

  committed
  c91a81d

  Copy full SHA for c91a81d

• typo.

  JonathanHenson

  committed
  4319bab

  Copy full SHA for 4319bab

• put the asm file back.

  JonathanHenson

  committed
  34de264

  Copy full SHA for 34de264

• compile guard on the sse cmul fallback.

  JonathanHenson

  committed
  1fa581a

  Copy full SHA for 1fa581a

• make sure that uber file has the right flags.

  JonathanHenson

  committed
  aaa5a02

  Copy full SHA for aaa5a02

• Move includes inside their macro guards.

  JonathanHenson

  committed
  048bf58

  Copy full SHA for 048bf58

Commits on Jan 30, 2024

• Add the null implementation back

  JonathanHenson

  committed
  333a6d3

  Copy full SHA for 333a6d3

• fix the null inclusion in cmake.

  JonathanHenson

  committed
  7021062

  Copy full SHA for 7021062

• add the generic implementation, renamed from null.

  JonathanHenson

  committed
  e028f3e

  Copy full SHA for e028f3e

• Shave that yak!

  JonathanHenson

  committed
  8516cc9

  Copy full SHA for 8516cc9

Commits on Jan 31, 2024

• just learned why a c-style cast is memory unsafe even when you know your boundary conditions are correct.

  JonathanHenson

  committed
  a43f739

  Copy full SHA for a43f739

• try just making sure the data is aligned first.

  JonathanHenson

  committed
  43e87ad

  Copy full SHA for 43e87ad

• fix constness.

  JonathanHenson

  committed
  4ac54af

  Copy full SHA for 4ac54af

• run formatter and fix conditional.

  JonathanHenson

  committed
  a7d22dd

  Copy full SHA for a7d22dd

• Use the correct branch this time.

  JonathanHenson

  committed
  0e31476

  Copy full SHA for 0e31476

Commits on Feb 1, 2024

• see what happens without an alignment on those arrays.

  JonathanHenson

  committed
  4870411

  Copy full SHA for 4870411

• see what happens without an alignment on those arrays.

  JonathanHenson

  committed
  0d4f728

  Copy full SHA for 0d4f728

• Try not telling ASAN quite so much info about the type and see if it still complains.

  JonathanHenson

  committed
  ef83ed9

  Copy full SHA for ef83ed9

• restrict the input size to always hit the sw implmentation on smaller than 16 bytes.

  JonathanHenson

  committed
  86604f0

  Copy full SHA for 86604f0

• Try intrinsics we can actually use everywhere.

  JonathanHenson

  committed
  19d5344

  Copy full SHA for 19d5344

• zmm, not xmm.

  JonathanHenson

  committed
  2e73b17

  Copy full SHA for 2e73b17

• Fix xlmuil intel build.

  JonathanHenson

  committed
  778ed1d

  Copy full SHA for 778ed1d

• Use cmake function more widely available.

  JonathanHenson

  committed
  96067a6

  Copy full SHA for 96067a6

Commits on Feb 5, 2024

• update crc32c and clean up macros.

  JonathanHenson

  committed
  3dfaaf6

  Copy full SHA for 3dfaaf6

• Don't do the generic fallback file as its unneeded.

  JonathanHenson

  committed
  1c2625c

  Copy full SHA for 1c2625c

• Remove unneeded clang format stuff.

  JonathanHenson

  committed
  4c51525

  Copy full SHA for 4c51525

• visual studio not saving without an explicit ctrl+s is some b.s.

  JonathanHenson

  committed
  729bf32

  Copy full SHA for 729bf32

• More build fixes.

  JonathanHenson

  committed
  0ab865e

  Copy full SHA for 0ab865e

• Update tests to have randomized input data.

  JonathanHenson

  committed
  2e61be3

  Copy full SHA for 2e61be3

Commits on Feb 6, 2024

• Fixed avx512 detection for compiling crc64_avx512 impl.

  JonathanHenson

  committed
  d86e10c

  Copy full SHA for d86e10c

Commits on Feb 8, 2024

• Added runner for apple arm.

  JonathanHenson

  committed
  9cd74b9

  Copy full SHA for 9cd74b9

• fix build of profiler run.

  JonathanHenson

  committed
  8fd01c7

  Copy full SHA for 8fd01c7

• use branch name for builder.

  JonathanHenson

  committed
  4eb218d

  Copy full SHA for 4eb218d

• use actual branch name.

  JonathanHenson

  committed
  c776234

  Copy full SHA for c776234

• why is it not using the host arch

  JonathanHenson

  committed
  8b11a21

  Copy full SHA for 8b11a21

• read the source code i guess...

  JonathanHenson

  committed
  3f37ea6

  Copy full SHA for 3f37ea6

• specify target.

  JonathanHenson

  committed
  49fefa1

  Copy full SHA for 49fefa1

• specify target.

  JonathanHenson

  committed
  49e1aa0

  Copy full SHA for 49e1aa0

• try a different target.

  JonathanHenson

  committed
  95bd82e

  Copy full SHA for 95bd82e

• Fix memory read for stack allocated buffers.

  JonathanHenson

  committed
  5983351

  Copy full SHA for 5983351

• Fix windows conversion errors on profile run.

  JonathanHenson

  committed
  94b6f5d

  Copy full SHA for 94b6f5d

• run profiler as part of tests.

  JonathanHenson

  committed
  1657ac5

  Copy full SHA for 1657ac5

• run profiler as part of tests.

  JonathanHenson

  committed
  499ec69

  Copy full SHA for 499ec69

• use correct value name for test steaps.

  JonathanHenson

  committed
  d86d672

  Copy full SHA for d86d672

• try just invoking ctest.

  JonathanHenson

  committed
  4a61537

  Copy full SHA for 4a61537

• use default tester path.

  JonathanHenson

  committed
  eb95b28

  Copy full SHA for eb95b28

Commits on Sep 3, 2024

• switch over crc64 to nvme flavor

  DmitriyMusatkin

  committed
  1657807

  Copy full SHA for 1657807

• fix benchmark

  DmitriyMusatkin

  committed
  15b9716

  Copy full SHA for 15b9716

• Merge branch 'main' into better_vectorization_and_crc64

  DmitriyMusatkin

  authored
  4915177

  Copy full SHA for 4915177

• lint

  DmitriyMusatkin

  committed
  0517612

  Copy full SHA for 0517612

• lets try again

  DmitriyMusatkin

  committed
  478c6cb

  Copy full SHA for 478c6cb

Commits on Sep 5, 2024

• minor

  DmitriyMusatkin

  committed
  2f55d46

  Copy full SHA for 2f55d46