Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix secure tunnel when messages sent quickly #101

Closed
wants to merge 7 commits into from
Closed

Fix secure tunnel when messages sent quickly #101

wants to merge 7 commits into from

Conversation

sfod
Copy link
Contributor

@sfod sfod commented Nov 9, 2023 •
edited
Loading

Always schedule WebSocket messages to be sent immediately.
Use tasks in mocked WebSocket to better reflect the real environment in tests.

Issue #, if available: aws/aws-iot-device-sdk-cpp-v2#649

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sfod sfod marked this pull request as ready for review November 10, 2023 00:05
bretambrose
bretambrose requested changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@bretambrose bretambrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If not servicing while pending write completion is causing problems then there is something else wrong in the implementation

@sfod
Copy link
Contributor Author

sfod commented Nov 10, 2023

Another fix is made: #102

@sfod sfod closed this Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bretambrose bretambrose bretambrose requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfod @bretambrose @sfodagain