Fix enable_sm_project function #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix enable_sm_project function issue which was introduced by braking change in urllib2
|
Thanks for working on it! Curious to know if you were able to perform a full deploy with this change made? |
|
I did incremental deployments while debugging. Tomorrow ill destroy and deploy from scratch |
|
I have destroyed and deployed again. All good |
dgraeber
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix enable_sm_project function issue which was introduced by braking change in urllib3 version 2. Similar issue: psf/requests#6443
Otherwise, error in cloudformation was raised
Description of changes:
Locking the version of urllib3 to be below 2.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.