Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use separate keys for signing and testing #27

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Conversation

trevorbonas
Copy link
Collaborator

Summary

Use separate keys for signing and testing.

Description

  • The names of the secrets for integration testing has been changed as follows:

    • AWS_IT_TEST_ACCESS_KEY_ID
    • AWS_IT_TEST_SECRET_ACCESS_KEY
  • The names of the secrets for signing Windows installers has been changed as follows:

    • AWS_SIGNING_ACCESS_KEY_ID
    • AWS_SIGNING_SECRET_ACCESS_KEY
    • AWS_SIGNING_ROLE_TO_ASSUME
    • AWS_SIGNING_ROLE_EXTERNAL_ID

Related Issue

N/A.

Additional Reviewers

N/A.

Copy link

github-actions bot commented Sep 20, 2024

Ubuntu 20.04 Debug Build Unit Test Results

0 files   -   1  0 suites   - 1   0s ⏱️ -1s
0 tests  - 73  0 ✔️  - 72  0 💤  - 1  0 ±0 
0 runs   - 72  0 ✔️  - 72  0 💤 ±0  0 ±0 

Results for commit 517f0f1. ± Comparison against base commit 041beca.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Sep 20, 2024

Ubuntu 20.04 Build Unit Test Results

0 files   -   1  0 suites   - 1   0s ⏱️ ±0s
0 tests  - 73  0 ✔️  - 72  0 💤  - 1  0 ±0 
0 runs   - 72  0 ✔️  - 72  0 💤 ±0  0 ±0 

Results for commit 517f0f1. ± Comparison against base commit 041beca.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@forestmvey forestmvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link

Ubuntu 20.04 Debug Build Integration Test Results

0 tests   - 400   0 ✔️  - 400   0s ⏱️ - 16m 45s
0 suites  -     1   0 💤 ±    0 
0 files    -     1   0 ±    0 

Results for commit 517f0f1. ± Comparison against base commit 041beca.

Copy link

Ubuntu 20.04 Build Integration Test Results

0 tests   - 400   0 ✔️  - 400   0s ⏱️ - 16m 42s
0 suites  -     1   0 💤 ±    0 
0 files    -     1   0 ±    0 

Results for commit 517f0f1. ± Comparison against base commit 041beca.

Copy link

Windows 2022 (x64) Build Unit Test Results

0 files   -   1  0 suites   - 1   0s ⏱️ -2s
0 tests  - 74  0 ✔️  - 73  0 💤  - 1  0 ±0 
0 runs   - 73  0 ✔️  - 72  0 💤  - 1  0 ±0 

Results for commit 517f0f1. ± Comparison against base commit 041beca.

Copy link

Windows 2022 (x32) Build Unit Test Results

0 files   -   1  0 suites   - 1   0s ⏱️ -2s
0 tests  - 74  0 ✔️  - 73  0 💤  - 1  0 ±0 
0 runs   - 73  0 ✔️  - 72  0 💤  - 1  0 ±0 

Results for commit 517f0f1. ± Comparison against base commit 041beca.

Copy link

Windows 2022 (x64) Build Integration Test Results

0 tests   - 400   0 ✔️  - 400   0s ⏱️ - 6m 2s
0 suites  -     1   0 💤 ±    0 
0 files    -     1   0 ±    0 

Results for commit 517f0f1. ± Comparison against base commit 041beca.

Copy link

Windows 2022 (x32) Build Integration Test Results

0 tests   - 400   0 ✔️  - 400   0s ⏱️ - 6m 26s
0 suites  -     1   0 💤 ±    0 
0 files    -     1   0 ±    0 

Results for commit 517f0f1. ± Comparison against base commit 041beca.

@trevorbonas trevorbonas merged commit c4dbbb9 into main Sep 20, 2024
9 of 15 checks passed
@trevorbonas trevorbonas deleted the multiple-keys branch September 20, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants