Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Logging for Ignored Records and Records Requested for Ingestion #60

Merged
merged 3 commits into from
May 1, 2024
Merged

Add Logging for Ignored Records and Records Requested for Ingestion #60

merged 3 commits into from
May 1, 2024

Conversation

forestmvey
Copy link
Contributor

Issue #, if available:

N/A

*Description of changes:

Add logging for number of records sent from Prometheus for ingestion, number of records ignored by the connector, and the number of records successfully ingested.

Changes Integrated:

  • - Validated ignored records is accurate
  • - Validated records successfully ingested is accurate
  • - Validated number of records requested for ingestion is accurate
  • - Validated IT tests pass
  • - Validated UT tests pass
  • - Validated correctness tests pass

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

forestmvey and others added 3 commits May 1, 2024 12:50
Signed-off-by: forestmvey <forestv@bitquilltech.com>
…ng note about info logs with number of records requested for ingestion, records ignored, and records successfully ingested.

Signed-off-by: forestmvey <forestv@bitquilltech.com>
…ogging

Add Logging for Ignored and Records Requested for Ingestion
@forestmvey forestmvey changed the title Add Logging for Ignored and Records Requested for Ingestion Add Logging for Ignored Records and Records Requested for Ingestion May 1, 2024
@forestmvey
Copy link
Contributor Author

Revisions were reviewed downstream therefore I am merging.

@forestmvey forestmvey merged commit 10338e5 into awslabs:main May 1, 2024
6 checks passed
@forestmvey forestmvey deleted the integ-add-ignored-and-requests-logging branch May 1, 2024 22:08
forestmvey added a commit to forestmvey/amazon-timestream-connector-prometheus that referenced this pull request May 7, 2024
…wslabs#60)

* Adding additional logging.

Signed-off-by: forestmvey <forestv@bitquilltech.com>

* Adding note for parameters used in one-click deployment section. Adding note about info logs with number of records requested for ingestion, records ignored, and records successfully ingested.

Signed-off-by: forestmvey <forestv@bitquilltech.com>

---------

Signed-off-by: forestmvey <forestv@bitquilltech.com>
forestmvey added a commit to forestmvey/amazon-timestream-connector-prometheus that referenced this pull request May 7, 2024
…wslabs#60)

* Adding additional logging.

Signed-off-by: forestmvey <forestv@bitquilltech.com>

* Adding note for parameters used in one-click deployment section. Adding note about info logs with number of records requested for ingestion, records ignored, and records successfully ingested.

Signed-off-by: forestmvey <forestv@bitquilltech.com>

---------

Signed-off-by: forestmvey <forestv@bitquilltech.com>
forestmvey added a commit to forestmvey/amazon-timestream-connector-prometheus that referenced this pull request May 7, 2024
…wslabs#60)

* Adding additional logging.

Signed-off-by: forestmvey <forestv@bitquilltech.com>

* Adding note for parameters used in one-click deployment section. Adding note about info logs with number of records requested for ingestion, records ignored, and records successfully ingested.

Signed-off-by: forestmvey <forestv@bitquilltech.com>

---------

Signed-off-by: forestmvey <forestv@bitquilltech.com>
forestmvey added a commit to forestmvey/amazon-timestream-connector-prometheus that referenced this pull request May 7, 2024
…wslabs#60)

* Adding additional logging.

Signed-off-by: forestmvey <forestv@bitquilltech.com>

* Adding note for parameters used in one-click deployment section. Adding note about info logs with number of records requested for ingestion, records ignored, and records successfully ingested.

Signed-off-by: forestmvey <forestv@bitquilltech.com>

---------

Signed-off-by: forestmvey <forestv@bitquilltech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant