Document the Lack of SigV4 Support #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: forestmvey <forestv@bitquilltech.com>
Signed-off-by: forestmvey <forestv@bitquilltech.com>
Signed-off-by: forestmvey <forestv@bitquilltech.com>
Add Note for the Lack of SigV4 Support
alexey-temnikov
approved these changes
Mar 26, 2024
Signed-off-by: forestmvey <forestv@bitquilltech.com>
forestmvey
added a commit
to forestmvey/amazon-timestream-connector-prometheus
that referenced
this pull request
May 7, 2024
* Adding note for lack of SigV4 support for the Prometheus Connector. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Add additional note about sidecar alternative. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Revisions to SigV4 note in README based on PR feedback. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Revisions based on PR feedback Signed-off-by: forestmvey <forestv@bitquilltech.com> --------- Signed-off-by: forestmvey <forestv@bitquilltech.com>
forestmvey
added a commit
to forestmvey/amazon-timestream-connector-prometheus
that referenced
this pull request
May 7, 2024
* Adding note for lack of SigV4 support for the Prometheus Connector. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Add additional note about sidecar alternative. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Revisions to SigV4 note in README based on PR feedback. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Revisions based on PR feedback Signed-off-by: forestmvey <forestv@bitquilltech.com> --------- Signed-off-by: forestmvey <forestv@bitquilltech.com>
forestmvey
added a commit
to forestmvey/amazon-timestream-connector-prometheus
that referenced
this pull request
May 7, 2024
* Adding note for lack of SigV4 support for the Prometheus Connector. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Add additional note about sidecar alternative. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Revisions to SigV4 note in README based on PR feedback. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Revisions based on PR feedback Signed-off-by: forestmvey <forestv@bitquilltech.com> --------- Signed-off-by: forestmvey <forestv@bitquilltech.com>
forestmvey
added a commit
to forestmvey/amazon-timestream-connector-prometheus
that referenced
this pull request
May 7, 2024
* Adding note for lack of SigV4 support for the Prometheus Connector. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Add additional note about sidecar alternative. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Revisions to SigV4 note in README based on PR feedback. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Revisions based on PR feedback Signed-off-by: forestmvey <forestv@bitquilltech.com> --------- Signed-off-by: forestmvey <forestv@bitquilltech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Add a note going over the lack of SigV4 support. The alternative of executing Prometheus with a sidecar is noted but we do not cover how to integrate executing with a sidecar in our documentation.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.