Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update template.yml and package.py for platform.al2023 runtime #42

Merged
merged 9 commits into from
Mar 14, 2024
Merged

Update template.yml and package.py for platform.al2023 runtime #42

merged 9 commits into from
Mar 14, 2024

Conversation

trevorbonas
Copy link
Contributor

Issue #, if available: N/A

Description of changes:

  • go1.x runtime is no longer supported for Lambda functions, causing deployments to fail, this has been updated to provided.al2023.
  • The connector version in template.yml has been changed from 1.1.0 to 1.0.0.
  • Handler has been changed to bootstrap to match the instructions to migrate from go1.x to provided.al2023.
  • The template will get the Lambda function code from the public bucket matching AWS::Region.
  • package.py now names the binary bootstrap, but still packages the binary and documentation in an archive named timestream-prometheus-connect-<os>-<arch>-<version>.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

trevorbonas and others added 9 commits January 4, 2024 12:33
"Prometheus Connector," and the version of the Prometheus connector, has been added to the User-Agent header, before the current value in the User-Agent header, which is the AWS SDK and its version.

Example from logs with DEBUG log-level:

```
User-Agent: Prometheus Connector/1.1.0 aws-sdk-go/1.35.7 (go1.21.1; darwin; arm64)
```

Also, details on what the `User-Agent` header value is for the Prometheus Connector has been added to the README.
README and serverless/DEVELOPER_README have been edited and now stress one-click deployment as the best way to deploy the connector.

Additionally, various grammatical, spelling, whitespace, and markdown formatting issues have been fixed. British English has been favoured. An outdated image was also changed.

GETTING_STARTED has been removed and its verification section has been moved to README.
- Broken or outdated links have been fixed.
- `RELEASE.md` has been updated with instructions for using the seven public S3 buckets and `template.yml`.
- All references to version `1.1.0` have been changed to `1.0.0`.
- `go1.x` runtime is no longer supported for Lambda functions, causing deployments to fail, this has been updated to `provided.al2023`.
- The connector version in `template.yml` has been changed from `1.1.0` to `1.0.0`.
- Handler has been changed to `bootstrap` to match the instructions to migrate from `go1.x` to `provided.al2023`.
- The template will get the Lambda function code from the public bucket matching `AWS::Region`.
- `package.py` now names the binary `bootstrap`, but still packages the binary and documentation in an archive named `timestream-prometheus-connect-<os>-<arch>-<version>`.
@forestmvey forestmvey self-requested a review March 14, 2024 21:15
@forestmvey forestmvey merged commit f52efb6 into awslabs:main Mar 14, 2024
6 checks passed
@forestmvey forestmvey deleted the integration branch March 14, 2024 21:27
forestmvey pushed a commit to forestmvey/amazon-timestream-connector-prometheus that referenced this pull request May 7, 2024
…bs#42)

* Add User-Agent documentation to README

* Add User-Agent header value

* Revise documentation

README and serverless/DEVELOPER_README have been edited and now stress one-click deployment as the best way to deploy the connector.

Additionally, various grammatical, spelling, whitespace, and markdown formatting issues have been fixed. British English has been favoured. An outdated image was also changed.

GETTING_STARTED has been removed and its verification section has been moved to README.

* Fix broken & outdated links & revamp RELEASE.md

- Broken or outdated links have been fixed.
- `RELEASE.md` has been updated with instructions for using the seven public S3 buckets and `template.yml`.
- All references to version `1.1.0` have been changed to `1.0.0`.

* Update template Go version & connector version in template

- `go1.x` runtime is no longer supported for Lambda functions, causing deployments to fail, this has been updated to `provided.al2023`.
- The connector version in `template.yml` has been changed from `1.1.0` to `1.0.0`.
- Handler has been changed to `bootstrap` to match the instructions to migrate from `go1.x` to `provided.al2023`.
- The template will get the Lambda function code from the public bucket matching `AWS::Region`.
- `package.py` now names the binary `bootstrap`, but still packages the binary and documentation in an archive named `timestream-prometheus-connect-<os>-<arch>-<version>`.
forestmvey pushed a commit to forestmvey/amazon-timestream-connector-prometheus that referenced this pull request May 7, 2024
…bs#42)

* Add User-Agent documentation to README

* Add User-Agent header value

* Revise documentation

README and serverless/DEVELOPER_README have been edited and now stress one-click deployment as the best way to deploy the connector.

Additionally, various grammatical, spelling, whitespace, and markdown formatting issues have been fixed. British English has been favoured. An outdated image was also changed.

GETTING_STARTED has been removed and its verification section has been moved to README.

* Fix broken & outdated links & revamp RELEASE.md

- Broken or outdated links have been fixed.
- `RELEASE.md` has been updated with instructions for using the seven public S3 buckets and `template.yml`.
- All references to version `1.1.0` have been changed to `1.0.0`.

* Update template Go version & connector version in template

- `go1.x` runtime is no longer supported for Lambda functions, causing deployments to fail, this has been updated to `provided.al2023`.
- The connector version in `template.yml` has been changed from `1.1.0` to `1.0.0`.
- Handler has been changed to `bootstrap` to match the instructions to migrate from `go1.x` to `provided.al2023`.
- The template will get the Lambda function code from the public bucket matching `AWS::Region`.
- `package.py` now names the binary `bootstrap`, but still packages the binary and documentation in an archive named `timestream-prometheus-connect-<os>-<arch>-<version>`.
forestmvey pushed a commit to forestmvey/amazon-timestream-connector-prometheus that referenced this pull request May 7, 2024
…bs#42)

* Add User-Agent documentation to README

* Add User-Agent header value

* Revise documentation

README and serverless/DEVELOPER_README have been edited and now stress one-click deployment as the best way to deploy the connector.

Additionally, various grammatical, spelling, whitespace, and markdown formatting issues have been fixed. British English has been favoured. An outdated image was also changed.

GETTING_STARTED has been removed and its verification section has been moved to README.

* Fix broken & outdated links & revamp RELEASE.md

- Broken or outdated links have been fixed.
- `RELEASE.md` has been updated with instructions for using the seven public S3 buckets and `template.yml`.
- All references to version `1.1.0` have been changed to `1.0.0`.

* Update template Go version & connector version in template

- `go1.x` runtime is no longer supported for Lambda functions, causing deployments to fail, this has been updated to `provided.al2023`.
- The connector version in `template.yml` has been changed from `1.1.0` to `1.0.0`.
- Handler has been changed to `bootstrap` to match the instructions to migrate from `go1.x` to `provided.al2023`.
- The template will get the Lambda function code from the public bucket matching `AWS::Region`.
- `package.py` now names the binary `bootstrap`, but still packages the binary and documentation in an archive named `timestream-prometheus-connect-<os>-<arch>-<version>`.
forestmvey pushed a commit to forestmvey/amazon-timestream-connector-prometheus that referenced this pull request May 7, 2024
…bs#42)

* Add User-Agent documentation to README

* Add User-Agent header value

* Revise documentation

README and serverless/DEVELOPER_README have been edited and now stress one-click deployment as the best way to deploy the connector.

Additionally, various grammatical, spelling, whitespace, and markdown formatting issues have been fixed. British English has been favoured. An outdated image was also changed.

GETTING_STARTED has been removed and its verification section has been moved to README.

* Fix broken & outdated links & revamp RELEASE.md

- Broken or outdated links have been fixed.
- `RELEASE.md` has been updated with instructions for using the seven public S3 buckets and `template.yml`.
- All references to version `1.1.0` have been changed to `1.0.0`.

* Update template Go version & connector version in template

- `go1.x` runtime is no longer supported for Lambda functions, causing deployments to fail, this has been updated to `provided.al2023`.
- The connector version in `template.yml` has been changed from `1.1.0` to `1.0.0`.
- Handler has been changed to `bootstrap` to match the instructions to migrate from `go1.x` to `provided.al2023`.
- The template will get the Lambda function code from the public bucket matching `AWS::Region`.
- `package.py` now names the binary `bootstrap`, but still packages the binary and documentation in an archive named `timestream-prometheus-connect-<os>-<arch>-<version>`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants