Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong ICE candidate priority calculation #612

Merged
merged 1 commit into from
Jul 17, 2020

Conversation

lherman-cs
Copy link
Contributor

The ice candidate calculation is wrong, the spec uses ^ symbol which represents power. But, in C, this symbol means XOR.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@lherman-cs lherman-cs changed the title Fix wrong candidate calculation Fix wrong candidate priority calculation Jul 14, 2020
@lherman-cs lherman-cs force-pushed the fix-priority-calculation branch from a2431ee to 0975a76 Compare July 14, 2020 21:15
@lherman-cs lherman-cs changed the title Fix wrong candidate priority calculation Fix wrong ICE candidate priority calculation Jul 14, 2020
@lherman-cs lherman-cs force-pushed the fix-priority-calculation branch from 0975a76 to fd5b761 Compare July 14, 2020 21:16
@lherman-cs lherman-cs force-pushed the fix-priority-calculation branch from fd5b761 to 4577b15 Compare July 14, 2020 21:20
Copy link
Contributor

@MushMal MushMal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow...

@lherman-cs
Copy link
Contributor Author

lherman-cs commented Jul 14, 2020

Oh wow...

@MushMal , exactly what I was thinking...

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2020

Codecov Report

Merging #612 into master will decrease coverage by 0.61%.
The diff coverage is 49.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #612      +/-   ##
==========================================
- Coverage   85.46%   84.85%   -0.62%     
==========================================
  Files          41       41              
  Lines        9584     9620      +36     
==========================================
- Hits         8191     8163      -28     
- Misses       1393     1457      +64     
Impacted Files Coverage Δ
src/source/PeerConnection/PeerConnection.c 84.09% <2.43%> (-5.89%) ⬇️
src/source/PeerConnection/Rtcp.c 43.33% <29.26%> (-7.52%) ⬇️
src/source/Srtp/SrtpSession.c 81.25% <33.33%> (-6.89%) ⬇️
src/source/PeerConnection/Rtp.c 73.71% <80.00%> (+0.06%) ⬆️
src/source/Ice/TurnConnection.c 93.11% <93.61%> (-0.47%) ⬇️
src/source/Ice/ConnectionListener.c 89.94% <100.00%> (-0.51%) ⬇️
src/source/Ice/IceAgent.c 94.92% <100.00%> (ø)
src/source/Ice/Network.c 81.57% <100.00%> (ø)
src/source/Rtcp/RtcpPacket.c 100.00% <100.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01f5160...ab547a2. Read the comment docs.

@lherman-cs lherman-cs force-pushed the fix-priority-calculation branch from 4577b15 to 2706a0e Compare July 16, 2020 17:15
@lherman-cs lherman-cs force-pushed the fix-priority-calculation branch from 2706a0e to ab547a2 Compare July 16, 2020 20:35
@lherman-cs lherman-cs merged commit 2336265 into master Jul 17, 2020
@lherman-cs lherman-cs deleted the fix-priority-calculation branch July 17, 2020 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants