Adding delete signaling channel API #346
Conversation
Adding tests and fixing some of the existing tests
| * Attempting to connect to the channel or send a message will result in an | ||
| * error or an unpredictable results after this call. | ||
| * | ||
| * NOTE: The call transitions the signaling client state machine to a terminal state |
There was a problem hiding this comment.
so what happens when signalingClientDeleteSync fails but the signaling channel is not successfully deleted? Is it still possible to delete it using the sdk?
There was a problem hiding this comment.
when delete channel is called, can we just terminate the state machine and wait on delete api to be finished? The delete channel operation seems orthogonal to any of the state machine operations. This way in the state machine we dont need to worry if about delete happening.
There was a problem hiding this comment.
The state is a terminal state. There isn't much left for the application to do but to either issue the delete call again or free the client.
We can't simply terminate the state machine as the delete needs the state machine for a couple of reasons - 1) in case of the stale credentials we will need to iterate to get token state and 2) in case of the delete failing with 400 we might have a bad version in which case we need to call describe.
Codecov Report
@@ Coverage Diff @@
## master #346 +/- ##
==========================================
- Coverage 87.03% 86.99% -0.05%
==========================================
Files 33 33
Lines 8078 8173 +95
==========================================
+ Hits 7031 7110 +79
- Misses 1047 1063 +16
Continue to review full report at Codecov.
|
Adding tests and fixing some of the existing tests
Issue #328
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.