handle EAGAIN and EWOULDBLOCK from sendTo #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #279 +/- ##
=========================================
- Coverage 87.06% 86.87% -0.2%
=========================================
Files 33 33
Lines 7964 7978 +14
=========================================
- Hits 6934 6931 -3
- Misses 1030 1047 +17
Continue to review full report at Codecov.
|
MushMal
reviewed
Mar 18, 2020
| if (result > 0) { | ||
| result = sendto(pSocketConnection->localSocket, pBuf, bufLen, 0, destAddr, addrLen); | ||
| } else if (result == 0) { | ||
| DLOGD("select() timed out"); |
There was a problem hiding this comment.
Are these WARNS? I see you have DLOGD here but in the else below you have DLOGE. See whether this is indeed an DLOGE or DLOGW.
Also, in case of DLOGE you could use CHK_ERR.
There was a problem hiding this comment.
I think all these should be DLOGD cuz higher layer should to agnostic to send failures.
There was a problem hiding this comment.
That's what I thought. In that case, please make the other DLOGD
919d09a to
63d94a2
Compare
MushMal
approved these changes
Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.