Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change onSctpOutboundPacket 3rd parameter type to SIZE_T #2097

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

stefankiesz
Copy link
Contributor

Issue #, if available:
#2094

What was changed?
The 3rd parameter of the onSctpOutboundPacket function.

Why was it changed?
To match the expected pointer-function signature of the second parameter of the usrsctp_init_nothreads function as defined here in the Usrsctp library.

How was it changed?
The parameter was changed from a ULONG to a SIZE_T.

What testing was done for the changes?
Will confirm from user that this resolved the issue, and will allow for the CI to pass.



By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@stefankiesz stefankiesz marked this pull request as draft January 9, 2025 20:28
@sirknightj
Copy link
Contributor

The CI confirms that PIC's SIZE_T macro does not match the actual size_t in certain cases, and the original authors went with ULONG as a workaround.
https://github.com/awslabs/amazon-kinesis-video-streams-pic/blob/c98c2a256a7bb3dfc4db41ae26d45e28ac7eec56/src/common/include/com/amazonaws/kinesis/video/common/CommonDefs.h#L329-L338

May need to do some more digging into why the original authors didn't use:

#include <stddef.h>

typedef size_t SIZE_T;

@stefankiesz stefankiesz marked this pull request as ready for review January 10, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants